-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide max buy multi octeracts #416
Open
jarboo
wants to merge
10
commits into
Pseudo-Corp:master
Choose a base branch
from
jarboo:Hide_max_buy_multi_octeracts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Octeracts: added buttons Hide Max and Buy Any/Max
Changed Shop buy Any to have the same behavior as Octeracts and Sing Upgrades
Sing Upgrades: added Hide Maxed and Buy Any/Max. Same behavior as Octeracts
Long live CSS Lint :)
KhafraDev
requested changes
Jan 10, 2023
@KhafraDev please merge this PR or at least approve it, it's 6 weeks old, I've already had to change it 3 times to resolve conflicts and I've implemented the changes you asked for. Several people are waiting for those changes. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Sing Upgrades and Octeracts:
For Quark Shop:
changed buy modes button behavior to be the same as Octeracts/Sing upgrades: the "Buy Any" mode is now available without using the Shift key (useful for mobile users).
On those 3 screens, multi buy is still available with shift+click on the upgrade, not depending on the current multi buy mode