Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User profile screen v2 #76

Merged
merged 19 commits into from
Apr 11, 2024
Merged

User profile screen v2 #76

merged 19 commits into from
Apr 11, 2024

Conversation

TheTexanCodeur
Copy link
Collaborator

This pull request implements a new version of the user profile screen. After discussion with the team, we came to the conclusion that the version of the last sprint wasn't pleasant to use. Here are the main features brought by this PR:

  1. A tab display for the personal posts and comments list : We realised that having two scrollable lists nested in another one resulted in a poor user experience. To simplify the navigation between posts and comments, we added a tab bar that switches from one list to the other. The navigation on the screen is thus more intuitive.

  2. General design rework : this new version tries to showcase a more minimalistic design. It is based on the mockup of the home page, so that it respects the general style of the app.

  3. Test file : more test were added for this new version as the new tab navigation needs to be tested. The tests check that the widgets are displayed and ensure that the navigation between the two columns (posts/comments) is working fine.

Capture d’écran 2024-04-09 à 11 10 37

@gruvw
Copy link
Collaborator

gruvw commented Apr 9, 2024

I think the new UI design is awesome and perfectly addresses our past criticisms, amazing work 🎆

Copy link
Collaborator

@yoannLafore yoannLafore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The profilage page looks beautiful !
It is pleasant and intuitive to use and will provide a great user experience !
The code is also nicely structured which will facilitate for the integration of the viewmodel in the future 👍

I have just made a minor suggestion below.

Also, I've noticed that for naming the widget keys you use spaces to separate the words.
So I have looked up to other code for UI components and found out that we are using camelCase for the home view and snake_case for the login view.
This really minor because we only use the Key object in the tests but we may want to adopt a particular convention (I guess we can discuss that with the team in the next meeting).

Overall, the PR looks good to me 👍
Thank you for your work !

lib/views/pages/profile/profile_page.dart Outdated Show resolved Hide resolved
@TheTexanCodeur
Copy link
Collaborator Author

TheTexanCodeur commented Apr 10, 2024

I added a few new features for this PR:

  1. Minor design changes : Some paddings were adjusted to make all widgets better fit together

  2. Mock data for the info cards : Each type of info card (bagde,post,comment) is now separated and implements a "ListTile" (just not badge) that displayes fake info for now.

  3. Adjusted tests : tests check that each type of info card is displayed now

Capture d’écran 2024-04-10 à 12 57 40

Copy link
Collaborator

@yoannLafore yoannLafore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes !
The addition of post and comment cards as well as shadows make the profile page looks even better 👍
I saw that you also added TODO comments at the places that will need to be modified when integrating the viewmodel, that's good and will make the integration easier.

I have just made little suggestions below (mostly typos).
Overall, very good job 🎉

lib/views/pages/profile/posts_info/info_card_comment.dart Outdated Show resolved Hide resolved
lib/views/pages/profile/posts_info/info_card_post.dart Outdated Show resolved Hide resolved
lib/views/pages/profile/posts_info/info_row.dart Outdated Show resolved Hide resolved
lib/views/pages/profile/posts_info/info_card_post.dart Outdated Show resolved Hide resolved
Copy link
Collaborator

@yoannLafore yoannLafore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, not all my suggestions were showing up so I re-added them here (I think I forgot to add them to the review...)

test/component/profile_page_test.dart Outdated Show resolved Hide resolved
lib/views/pages/profile/profile_page.dart Outdated Show resolved Hide resolved
lib/views/pages/profile/user_info/user_account.dart Outdated Show resolved Hide resolved
Copy link
Collaborator

@Aderfish Aderfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, the design looks great! This PR looks good to me.

@TheTexanCodeur TheTexanCodeur requested a review from CHOOSEIT April 11, 2024 07:52
@TheTexanCodeur TheTexanCodeur linked an issue Apr 11, 2024 that may be closed by this pull request
Copy link
Member

@CHOOSEIT CHOOSEIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheTexanCodeur TheTexanCodeur merged commit 9b285d8 into main Apr 11, 2024
2 checks passed
@TheTexanCodeur TheTexanCodeur deleted the user-profile-v2 branch April 11, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework user profile UI after change of concept
5 participants