create new post screen #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put a static maxLines for now, but this should depend on the available space.
The new post page is static for now, it will connect to the repository later.
Did this using Expanded. A problem is that the bottom part is now clickable. I don't know how to fix that. I tried using a spacer, but it does not mix well with the Expanded widget.
Closed
Only merge conflict was due to separation of login_page into 2 files in login package.
|
Nice work, this might require a small amount of UI code refactoring, similar to #37 (comment) and #38 (comment). |
Was using the mocked proxima page and navigating to new post page first, but this is not sustainable. These tests should only test the NewPostPage widget.
Text and hint content is now private, and keys are used for testing.
|
Thank you for the feedback, I did the refactoring to make the code more readable. I also changed the tests so that they only use this page and not the whole app to run. Please tell me if you find anything else that should be improved. |
| onPressed: () { | ||
| // TODO open tag and notification settings overlay | ||
| }, | ||
| icon: const Icon(Icons.settings), |
There was a problem hiding this comment.
I think it would be a better idea to put the notification settings button in the top left of the screen (in a lot if app it's his default position).
TheTexanCodeur
approved these changes
Mar 29, 2024
No conflict except deleting the old home page file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29,
This PR implements the new post screen.
The post button checks that the title and body are not empty. However it does not yet connect to the database, and there is therefore no viewmodel yet.
The settings button is not implemented yet. It will be implemented when user notifications and tag functionality will be implemented.