Skip to content

Woops i managed to rename it instead of using the Commit Message #16

Woops i managed to rename it instead of using the Commit Message

Woops i managed to rename it instead of using the Commit Message #16

Triggered via push March 16, 2024 23:44
Status Success
Total duration 42s
Artifacts

build.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

11 warnings
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-dotnet@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
build: Prowl.Runtime/Components/Camera.cs#L196
#warning: 'TODO: Atm gizmos is handled in a RenderObject method, but it should all be inside Update() including rendering but that will happen over the rendering overhaul, so for now reset every render (when rendering overhaul, it should be once per frame)'
build: Prowl.Runtime/GBuffer.cs#L25
#warning: 'TODO: Dont always use 32bits, optomize this and use only whats absolutely needed, some precision loss is ok as long as it doesnt hurt visuals much, normals for example could probably be 16'
build: Prowl.Runtime/Resources/Material.cs#L239
#warning: 'TODO: AssetID isnt reliable, especially if the shader is generated at runtime since then there wont be an asset ID '
build: Prowl.Runtime/GBuffer.cs#L26
#warning: 'TODO: Switch to a singular 16bit "Material" buffer, AO, Rough, Metal, the final channel would be 16 bools, Lit, Fog, etc'
build: Prowl.Runtime/Utils/SerializedAsset.cs#L19
#warning: 'TODO: Somehow record Dependencies - reflection to find all AssetRef instances and store them in a list?'
build: Prowl.Runtime/GameObject/MonoComponent.cs#L107
#warning: '"Need to apply this to Component Deletion in Inspector, to make sure not to delete dependant Components"'
build: Prowl.Runtime/Math/Vector2.cs#L137
Nullability of reference types in type of parameter 'format' of 'string Vector2.ToString(string format, IFormatProvider formatProvider)' doesn't match implicitly implemented member 'string IFormattable.ToString(string? format, IFormatProvider? formatProvider)' (possibly because of nullability attributes).
build: Prowl.Runtime/Math/Vector2.cs#L137
Nullability of reference types in type of parameter 'formatProvider' of 'string Vector2.ToString(string format, IFormatProvider formatProvider)' doesn't match implicitly implemented member 'string IFormattable.ToString(string? format, IFormatProvider? formatProvider)' (possibly because of nullability attributes).
build: Prowl.Runtime/Color.cs#L6
'Color' overrides Object.Equals(object o) but does not override Object.GetHashCode()
build: Prowl.Runtime/Color.cs#L6
'Color' defines operator == or operator != but does not override Object.GetHashCode()