-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce redundant debug-logging on larger networks #3116
Draft
vvp
wants to merge
6
commits into
ProvableHQ:staging
Choose a base branch
from
eqlabs:fix/improve-debug-log
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+84
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljedrz
reviewed
Feb 22, 2024
ljedrz
reviewed
Feb 22, 2024
ljedrz
reviewed
Feb 22, 2024
ljedrz
previously approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, left a few comments 👍
joske
approved these changes
Feb 22, 2024
SplittyDev
approved these changes
Feb 22, 2024
81b72df
to
ff45d26
Compare
raychu86
reviewed
Mar 9, 2024
Co-authored-by: ljedrz <[email protected]> Signed-off-by: Vesa-Ville <[email protected]>
Co-authored-by: ljedrz <[email protected]> Signed-off-by: Vesa-Ville <[email protected]>
Co-authored-by: ljedrz <[email protected]> Signed-off-by: Vesa-Ville <[email protected]>
Co-authored-by: Raymond Chu <[email protected]> Signed-off-by: Vesa-Ville <[email protected]>
648c00a
to
025ff63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In larger BFT networks, some of the recurring debug-logging events are currently unnecessarily noisy which makes observing node/network operation harder. This PR improves this in two fronts.
Logging only validator set changes. Currently, each nodes, this means redundant debug log lines, every 15 seconds. This PR instead only logs the validator set differences between each heartbeat, indicating connected and disconnected validators with
Gateway
logs all connected validators (their SocketAddrs and Aleo addresses) in every heartbeat. During a stable operation in network of+
and-
symbols . For example:As this change involves using a
RWLock
and doing some extra allocations, it is only enabled whentracing::Level::DEBUG
is enabled.Folding batch proposal resends into a single line. Currently, when resending proposals,
Primary::propose_batch()
logs a single line per each non-signerSocketAddr
s. This is repeated every 2.5 seconds and during network events, can result in a lot of redundant log spam. This PR folds the information content into a single debug-log line before resending the proposals.I estimate that in larger networks these changes can reduce the total aggregated log size significantly due to combinatorial explosion - using my recent debug log of a 16-hour test run in a 50-node devnet as an example the reduction was ~50% (of a total of 7.1M lines, 3.5M lines were removed).