Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add playwright tests #919

Closed

Conversation

robwafle
Copy link

@robwafle robwafle commented Aug 20, 2024

Motivation

Add playwright tests to the react template so we can eventually add these in the build and keep the template stable.

Test Plan

Ran tests locally for now, they passed locally and they can be added to ci at any time

Copy link
Collaborator

@onetrickwolf onetrickwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey general idea looks good but you generally want to avoid manual waiting in e2e tests. Please look at these docs: https://docs.cypress.io/guides/references/best-practices#Unnecessary-Waiting

https://playwright.dev/docs/actionability

The times will not be consistent across machines, network conditions, etc this can lead to flake and also slows the tests down if they load faster than the manual wait.

@robwafle robwafle closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants