Removes extra caller input from transfer_public #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaketarnow
approved these changes
Jul 29, 2024
jaketarnow
requested review from
christianwwwwwwww
and removed request for
Pauan
iamalwaysuncomfortable
requested changes
Aug 1, 2024
There was a problem hiding this comment.
These do not include the changes to the javascript end of the SDK nor the Provable.tools website. Those signatures should also be updated - #907 addresses these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Executing a public transfer using the program manager
transferfunction fails as thetransfer_publicoption inwasm/src/programs/manager/transfer.rshas 3 inputs not 2 as required by the program function as you can see here https://explorer.aleo.org/program/credits.aleo. Removing the first parameter should resolve this, and also thecalleraddress parameter is not required for the transfer function.Test Plan
Re compile the rust to wasm and test out executing
ProgramManager.transfer({amount}, {recipient}, {transfer_type}, {fee}).