Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update] Update SDK methods to support latest credits.aleo method signatures #891

Merged
merged 6 commits into from
Jul 2, 2024

Conversation

iamalwaysuncomfortable
Copy link
Collaborator

Motivation

The latest SnarkVM revision published on the AleoNet/SnarkVM repo (rev: d170a9f) has updated the credits.aleo program to support ARC-41.

This PR updates the Aleo-wasm snarkVM rev to d170a9f and updates all method signatures in the SDK to match the latest method signatures in credits.aleo, it also adds the bond_validator and transfer_public_as_signer methods to the SDK's api.

The work in this PR is meant to represent a release candidate for the SDK that is updated to work with the currently released Aleo Testnet.

Test Plan

All unit tests are now updated to reflect the latest changes.

Related PRs

The work in this PR is a continuation of the work done in #884.

@iamalwaysuncomfortable iamalwaysuncomfortable changed the title [Update] Update SDK methods to support latest credits.aleo method signatures [Update] Update SDK methods to support latest credits.aleo method signatures Jul 1, 2024
Pauan
Pauan previously requested changes Jul 2, 2024
sdk/src/offline-key-provider.ts Show resolved Hide resolved
sdk/src/program-manager.ts Show resolved Hide resolved
wasm/src/programs/manager/transfer.rs Outdated Show resolved Hide resolved
wasm/src/programs/verifying_key/credits.rs Show resolved Hide resolved
wasm/src/programs/verifying_key/credits.rs Show resolved Hide resolved
wasm/src/programs/verifying_key/credits.rs Show resolved Hide resolved
Copy link
Collaborator

@Pauan Pauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iamalwaysuncomfortable iamalwaysuncomfortable merged commit 4b7103f into testnet3 Jul 2, 2024
10 checks passed
@iamalwaysuncomfortable iamalwaysuncomfortable deleted the update/snarkvm-d170a9f branch July 2, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants