-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Update] Update SDK methods to support latest credits.aleo
method signatures
#891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…redits.aleo methods and method signatures
iamalwaysuncomfortable
changed the title
[Update] Update SDK methods to support latest credits.aleo method signatures
[Update] Update SDK methods to support latest Jul 1, 2024
credits.aleo
method signatures
Pauan
previously requested changes
Jul 2, 2024
This reverts commit bd77062.
Pauan
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The latest SnarkVM revision published on the AleoNet/SnarkVM repo (rev: d170a9f) has updated the
credits.aleo
program to support ARC-41.This PR updates the Aleo-wasm snarkVM rev to
d170a9f
and updates all method signatures in the SDK to match the latest method signatures incredits.aleo
, it also adds thebond_validator
andtransfer_public_as_signer
methods to the SDK's api.The work in this PR is meant to represent a release candidate for the SDK that is updated to work with the currently released Aleo Testnet.
Test Plan
All unit tests are now updated to reflect the latest changes.
Related PRs
The work in this PR is a continuation of the work done in #884.