-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Improve HMR and build performance of aleo.tools #618
Conversation
Currently have new build in |
…bsite-build-performance # Conflicts: # website/package.json # website/src/workers/worker.js
Unfortunately, a bug in vite means we still have to use Webpack for production builds, but this PR is still worth merging considering how much it speeds up the dev server spinup and HMR. Tracking vite bug here: #628; I will remove the web pack once this bug is resolved. |
Some issues with how this deploys to netlify, making a few small changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, I'd say pending the merge of the new fixes upstream, this looks fine to me.
…bsite-build-performance # Conflicts: # Cargo.lock # website/package.json
Okay fixed the vite build. Had to do a small patch for Patch implemented via root (patches do not work in workspaces apparently) I attempted to find a solution that would work for both webpack and vite so I could submit it as a PR to |
Okay this should be good to go. Decided to go back to the webpack build for now after some more research I am pretty convinced this is actually best solved with a vite patch rather than patching Currently deployed to https://staging.aleo.tools/ seems to be fine! There's a few non-ideal configurations from the hybrid approach but nothing major, still a huge improvement. Hopefully can be cleared up in the near future. In staging will throw that it is missing |
Motivation
Resolves #617
Test Plan
Functionality should be identical but compile time and hot reload should be significantly faster (roughly 50x performance in my tests).