Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support Finalize Scope, New Transaction Types, and Public Balances #594

Merged
merged 19 commits into from
Jun 22, 2023

Conversation

iamalwaysuncomfortable
Copy link
Collaborator

@iamalwaysuncomfortable iamalwaysuncomfortable commented Jun 9, 2023

Motivation

The upcoming release of SnarkVM v0.12.3 will release a fully functional finalize scope that allows on-chain execution. As part of this the transfer function within credits.aleo which allows both private and public value transfers and transformations between them.

This PR adds support for this functionality within the SDK prior to the official release of SnarkVM in order to provide developers the tools to immediately begin working with this new functionality within the SDK when the release goes live in the Aleo testnet3.

Test Plan

  • Extra tests to test finalize functionality and new transaction types will be added prior to release

Related PRs

Benchmark finalize instructions
Finalize Fees

@iamalwaysuncomfortable iamalwaysuncomfortable marked this pull request as ready for review June 21, 2023 23:50
Copy link
Contributor

@collinc97 collinc97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamalwaysuncomfortable iamalwaysuncomfortable merged commit 7d60f62 into testnet3 Jun 22, 2023
6 checks passed
@iamalwaysuncomfortable iamalwaysuncomfortable deleted the feat/new-transfer-types branch June 22, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants