Fix up Display implementations for AST nodes. #28491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mikebenfield
commented
Jan 24, 2025
mikebenfield
commented
mikebenfield
force-pushed
the
display-code
branch
from
5f870f5 to
f91ef0b
Compare
d0cd
reviewed
Jan 27, 2025
mikebenfield
force-pushed
the
const-folding3
branch
2 times, most recently
from
8a9ce53 to
f7503f2
Compare
mikebenfield
force-pushed
the
display-code
branch
2 times, most recently
from
f77f670 to
ea173f8
Compare
mikebenfield
force-pushed
the
const-folding3
branch
4 times, most recently
from
9f6ef6b to
cebc1df
Compare
Get details right like parens depending on precedence, semicolons after statements only when warranted, etc. I haven't extensively tested this yet, so there are likely places where it does the wrong thing, but this will be a slightly more principled implementation we can fix up as needed.
mikebenfield
force-pushed
the
display-code
branch
from
ea173f8 to
76ba42f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.