Remove () expressions and () type except returns. #28485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0cd
reviewed
Jan 7, 2025
d0cd
reviewed
Jan 7, 2025
d0cd
reviewed
Jan 7, 2025
d0cd
approved these changes
Jan 7, 2025
mikebenfield
force-pushed
the
remove-unit2
branch
from
e8423c2 to
96841ca
Compare
() serves no purpose beyond indicating the absence of return values, at least until/unless we have some kind of type polymorphism.
mikebenfield
force-pushed
the
remove-unit2
branch
from
96841ca to
e62fe4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
()expressions and the()type except in function output types.This is because
()serves no purpose beyond indicating the absence of return values, at least until/unless we have some kind of type polymorphism.