Retry up to 10 times when error requesting Koina predictions #3197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chambm
reviewed
Oct 17, 2024
| @@ -142,8 +143,11 @@ protected void UpdateSearchEngineProgress(IProgressStatus status) | |||
| } | |||
|
|
|||
| // look at the last 10 lines for the same message and if found do not relog the same message | |||
| if (_progressTextItems.Skip(Math.Max(0, _progressTextItems.Count - 10)).Any(entry => entry.Message == message)) | |||
There was a problem hiding this comment.
It seems this blatant missing optimization has been in .NET since 2016 or so, but alas doesn't seem to have made it into Framework.
chambm
approved these changes
Oct 17, 2024
brendanx67
reviewed
Oct 17, 2024
pwiz_tools/Skyline/app.config
Outdated
| @@ -690,7 +690,7 @@ | |||
| <setting name="MixedMoleculeSettingsTab" serializeAs="String"> | |||
| <value>0</value> | |||
| </setting> | |||
| <setting name="Prosit" serializeAs="String"> | |||
| <setting name="Koina" serializeAs="String"> | |||
There was a problem hiding this comment.
Leave these changes for Brian Pratt's static analysis PR. Stick to only the one settings change required for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's one way that we could deal with errors that we get from the Koina server.
However, given that the failure always seems to happen on the 1000th request, it should probably be fixed on the server side.
This change makes it retry up to 10 times.
Other changes: