-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry up to 10 times when error requesting Koina predictions #3197
base: master
Are you sure you want to change the base?
Conversation
@@ -142,8 +143,11 @@ protected void UpdateSearchEngineProgress(IProgressStatus status) | |||
} | |||
|
|||
// look at the last 10 lines for the same message and if found do not relog the same message | |||
if (_progressTextItems.Skip(Math.Max(0, _progressTextItems.Count - 10)).Any(entry => entry.Message == message)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this blatant missing optimization has been in .NET since 2016 or so, but alas doesn't seem to have made it into Framework.
pwiz_tools/Skyline/app.config
Outdated
@@ -690,7 +690,7 @@ | |||
<setting name="MixedMoleculeSettingsTab" serializeAs="String"> | |||
<value>0</value> | |||
</setting> | |||
<setting name="Prosit" serializeAs="String"> | |||
<setting name="Koina" serializeAs="String"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave these changes for Brian Pratt's static analysis PR. Stick to only the one settings change required for this PR.
Here's one way that we could deal with errors that we get from the Koina server.
However, given that the failure always seems to happen on the 1000th request, it should probably be fixed on the server side.
This change makes it retry up to 10 times.
Other changes: