waters_connect support in Skyline and pwiz #3170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ike: https://devconnect.waters.com:48444/?sampleSetId=<sample set id>&injectionId=<injection id> - added support for connecting to and browsing waters_connect servers in Skyline * redirected UNIFI to use ABI's protobuf-net.dll (I don't think it was ever actually using the unifi-protobuf-net.dll) * refactored ParallelDownloadQueue into a separate class shared by UnifiData::Impl and WatersConnectImpl (a new implementation derived from UnifiData::Impl, but WatersConnect uses a separate queue for each channel) * added optional performance timers in VendorReaderTestHarness * disabled lockmass prompt for UNIFI in Skyline as it does not support it * improved error handling in Skyline UNIFI browsing
* fixed Linux compile
* fixed advanced connection settings (identity server) not being shown for waters_connect * fixed XML serialization for waters_connect_account * added tests for the above issues (refactored and renamed existing Unifi tests to work for both APIs)
* added extraction of precursor and product m/z for SIM/SRM chromatograms from metadata first rather than parsing id
* reverted ChromKey.FromId behavior change so it uses values parsed from ID first and falls back to metadata if parsing fails
…ull-scan graph but ensure the chromatogram curves are loaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://devconnect.waters.com:48444/?sampleSetId=<sample set id>&injectionId=<injection id>