Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore challenging intermittent nightly test failures #3148

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
da45bcb
add some debug code to Statistics.Split
bspratt Sep 5, 2024
759fe1c
try to stabilize these tests by using AbstractFunctionalTestEx.OpenDo…
bspratt Sep 5, 2024
c074520
per MattC email, try eliminating call to DiaUmpire.Config.GetConfigF…
bspratt Sep 9, 2024
737aff4
Merge branch 'master' into Skyline/work/20240905_what_is_up_with_test…
bspratt Sep 9, 2024
0c1e803
trying to determine with TestMS1Tutorial is hanging - added Program.R…
bspratt Sep 9, 2024
ff5c256
Merge branch 'Skyline/work/20240905_what_is_up_with_tests_on_jason_xp…
bspratt Sep 9, 2024
2be4d07
TestRunner launches ProcDump (if installed, see https://learn.microso…
bspratt Sep 30, 2024
b0c7b95
Merge branch 'master' into Skyline/work/20240905_what_is_up_with_test…
bspratt Oct 1, 2024
b8cb553
Merge branch 'Skyline/work/20240905_what_is_up_with_tests_on_jason_xp…
bspratt Oct 1, 2024
d95f715
SkylineNightly: set git's http.postBuffer size to 500MB to help with …
bspratt Oct 1, 2024
e5ac552
per Nick suggestion, aply the http buffer size change only for the du…
bspratt Oct 1, 2024
78c4729
add an informative message about SysInternals ProcDump when it isn't …
bspratt Oct 2, 2024
9e13daf
slightly more verbose launch for ProcDump
bspratt Oct 7, 2024
da1aa53
try to build as release with debug symbols retained
bspratt Oct 8, 2024
006a64a
Merge branch 'master' into Skyline/work/20240905_what_is_up_with_test…
bspratt Oct 8, 2024
88265ee
Merge branch 'master' into Skyline/work/20240905_what_is_up_with_test…
brendanx67 Oct 16, 2024
9d3c717
Merge branch 'master' into Skyline/work/20240905_what_is_up_with_test…
bspratt Oct 17, 2024
f4e8579
Merge branch 'master' into Skyline/work/20240905_what_is_up_with_test…
bspratt Oct 17, 2024
39158cd
Merge branch 'master' into Skyline/work/20240905_what_is_up_with_test…
bspratt Oct 18, 2024
a7d7e03
trying to leave debug symbols in confuses bjam
bspratt Oct 19, 2024
568acfe
Merge branch 'Skyline/work/20240905_what_is_up_with_tests_on_jason_xp…
bspratt Oct 19, 2024
fe9334f
Another try at a TC release build with debug symbols on - backs out a…
bspratt Oct 22, 2024
0a88db1
Merge branch 'master' into Skyline/work/20240905_what_is_up_with_test…
bspratt Oct 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pwiz_tools/Skyline/SkylineTester/TabBuild.cs
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,8 @@ public static bool CreateBuildCommands(

commandShell.Add("#@ Checking out {0} source files...\n", branchName);
commandShell.Add("# Checking out {0} source files...", branchName);
commandShell.Add("# Setting git's http postBuffer size to 500MB, should help with clone on unstable networks");
commandShell.Add("{0} config --global http.postBuffer 524288000", git.Quote());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing git config --global has the effect of modifying the .gitconfig file in the user's home directory.

I would recommend instead adding -c http.postBuffer=524288000 to the actual clone commands:
git -c http.postBuffer=524288000 clone ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

// Add the --progress flag for richer logging - git leaves out most progress info when it isn't writing to an actual terminal
if (branchName.Contains("master"))
{
Expand Down
14 changes: 14 additions & 0 deletions pwiz_tools/Skyline/TestRunner/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1442,6 +1442,20 @@ private static bool RunTestPasses(
}

runTests.Log("\r\n");

try
{
// Run procdump if installed
var process = new Process();
process.StartInfo.FileName = "procdump.exe";
process.StartInfo.Arguments = $@"-accepteula -ma -mk -h TestRunner {dmpDir}";
process.Start();
runTests.Log("# launched ProcDump to try to catch hangs in TestRunner");
}
catch (Exception)
{
// ignored, presumably ProcDump is not installed
}
}

if (commandLineArgs.ArgAsBool("clipboardcheck"))
Expand Down