Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIA search workflow UI changes #3134

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

chambm
Copy link
Member

@chambm chambm commented Aug 26, 2024

  • reworked DIA workflow radio button to work with and without DIA-Umpire
  • added checkboxes next to DIA workflow for DIA-Umpire and Gas Phase Fractionation
  • added faster TestDiaSearch test (sharing TestDiaSearch DiaUmpire code)
  • updated audit logs

image

- added checkboxes next to DIA workflow for DIA-Umpire and Gas Phase Fractionation
* added faster TestDiaSearch test (sharing TestDiaSearch DiaUmpire code)
* updated audit logs
@chambm
Copy link
Member Author

chambm commented Aug 29, 2024

@brendanx67 I added a screenshot of the main UI change here.

@brendanx67
Copy link
Contributor

Should DIA-Umpire be on by default? I wonder if we should get rid of "with MS1 filtering" from the DDA option. That is our own terminology and somewhat fading into the past. We may also want to improve the wizard to allow the DDA extraction option for MS/MS now that we have that. Quant is still based on MS1, but I am not sure "with MS1 filtering" adds anything but term that never really caught on.

@brendanx67
Copy link
Contributor

Maybe also a tip on "DIA-Umpire" explaining that it provides deconvolution of chimeric DIA MS/MS spectra to single-precursor, pseudo-DDA MS/MS spectra.

@brendanx67
Copy link
Contributor

Also a tip about what "Gas phase fractionation" is. It should not be in title case despite the fact that it is given the acronym GPF. DIA-Umpire is a proper name, which is why both words get capitalized.

* fixed MSFragger to look for correct pepXML file extension based on data_type parameter instead of workflow setting
@chambm
Copy link
Member Author

chambm commented Oct 1, 2024

Maybe also a tip on "DIA-Umpire" explaining that it provides deconvolution of chimeric DIA MS/MS spectra to single-precursor, pseudo-DDA MS/MS spectra.
Also a tip about what "Gas phase fractionation" is. It should not be in title case despite the fact that it is given the acronym GPF. DIA-Umpire is a proper name, which is why both words get capitalized.

Done. Without going into any UI reorganization, the last thing to do here is to make the GPF checkbox import the given files as a multi-run replicate. I'm not sure offhand how to do that but I will look at the import results dialog to figure it out.

@brendanx67
Copy link
Contributor

I do think it would be better to have the user just choose "DIA" and then make these choices later on pages with more space to explain better what they are choosing.

@brendanx67
Copy link
Contributor

image

It is a little weird that we offer the choice of DIA Umpire on the first page, but don't really get into explaining it until this page.

@brendanx67
Copy link
Contributor

They are 5 pages apart.

It may have seemed to make sense to add the checkbox on the first page, because we used to say "DIA with DIA-Umpire" but that was just meant to inform people of an important aspect of the search over which they had no control. If we are going to give them control of that, then all they really need to care about at this stage is that they are telling us they are supplying DIA data.

The point of the original text was to tell them early before they went through those 5 other pages and then suddenly realized we were going to be doing DIA-Umpire doconvolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants