Skip to content

Commit

Permalink
Minor formatting changes
Browse files Browse the repository at this point in the history
  • Loading branch information
ffakenz committed May 6, 2024
1 parent 940bc94 commit d53999e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 2 additions & 0 deletions backend/src/bounty/api/claim.rs
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ pub async fn claim_impl(
github_pr_id: github_pr_id.clone(),
}),
Some(pull_request) => {
// TODO: unify GitHub errors
// FIXME: remove unwraps
let pr_response: Result<PrDetailsResponse, MergeDetailsErr> = github_client
.get_merged_details(extract_pull_number(&github_pr_id).unwrap())
.await;
Expand Down
4 changes: 2 additions & 2 deletions backend/src/bounty/api/deposit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ pub enum DepositErr {
pub type DepositReceipt = Result<Tokens, DepositErr>;

pub async fn deposit_impl() -> DepositReceipt {
// FIXME check caller equals the owner who initialized the bounty.
// FIXME: check caller equals the owner who initialized the bounty.
let caller = caller();
let icrc1_token_canister_id = Principal::from_text(MAINNET_ICRC1_LEDGER_CANISTER_ID)
.expect("Wrong MAINNET_ICRC1_LEDGER_CANISTER_ID");
Expand Down Expand Up @@ -59,7 +59,7 @@ async fn deposit_icrc1(
},
amount: available.clone(),
fee: Some(icrc1_token_fee),
// TODO enhance memo text
// TODO: enhance memo text
memo: Some(Memo(0)),
created_at_time: None,
};
Expand Down
1 change: 1 addition & 0 deletions backend/src/provider/github/api/get_fixed_by.rs
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ fn remove_github_prefix(url: &str) -> String {
url.replace("https://github.com/", "")
}

// TODO: use extract_regex
fn extract_pull_request(html: &str) -> Option<String> {
// Define a regular expression pattern to match the href attribute
let re = Regex::new(r#"<a\s+[^>]*?href="(.*?)"[^>]*?>"#).unwrap();
Expand Down

0 comments on commit d53999e

Please sign in to comment.