Skip to content

Commit

Permalink
Adding TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
ffakenz committed May 11, 2024
1 parent 562e075 commit 8c37063
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions backend/src/bounty/api/accept.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ pub fn accept_impl(
updated_at: now
};
// TODO: Check contributor it's registered and github_issue_id exists on github
// TODO check the issue is not claimed and still open!
issue.bounty.accepted_prs.insert(github_pr_id.clone(), pr);
}
}
Expand Down
1 change: 1 addition & 0 deletions backend/src/bounty/api/register_issue.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ pub fn register_issue_impl(

};
// TODO: Check contributor it's registered and github_issue_id exists on github
// TODO check the issue is still open!
bounty_canister
.github_issues
.insert(github_issue_id.clone(), github_issue);
Expand Down
1 change: 1 addition & 0 deletions backend/src/bounty/api/unregister_issue.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ pub fn unregister_issue_impl(github_issue_id: IssueId) -> UnRegisterIssueReceipt

if issue_exists {
// TODO: Check contributor it's registered and github_issue_id exists on github
// TODO check the issue is claimed, return error if not!
bounty_canister.github_issues.remove(&github_issue_id);
}
None
Expand Down

0 comments on commit 8c37063

Please sign in to comment.