Resolve tags by name instead of id #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prokyonn
force-pushed
the
enhancement/tag-resolver
branch
from
fbf2c12 to
e1c5cfd
Compare
| @@ -32,11 +32,11 @@ public function __construct( | |||
|
|
|||
| public function load(array $ids, ?string $locale, array $params = []): array | |||
| { | |||
| $result = $this->tagRepository->findBy(['id' => $ids]); | |||
| $result = $this->tagRepository->findBy(['name' => $ids]); | |||
There was a problem hiding this comment.
is this migrated correctly by the phpcr migration bundle? Currently tags are stored as ids in the excerpt in phpcr.
There was a problem hiding this comment.
No it doesn't
But tbh I would like it more to save the id instead of the name, but then we would need to adjust it also on the FE 🤔
What would be the best way to go forward?
|
|
||
| $mappedResult = []; | ||
| foreach ($result as $tag) { | ||
| $mappedResult[$tag->getId()] = $tag->getName(); | ||
| $mappedResult[$tag->getName()] = $tag->getName(); |
There was a problem hiding this comment.
Thinking about remove the loader if we just rereturn the names here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Resolve tags by name instead of id.
Why?
Because the react admin always works with the
nameof the tag instead of the id.To Do