Skip to content

Remove seaport 1.5 code #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions src/sdk.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import EventEmitter = require("events");
import { Seaport } from "@opensea/seaport-js";
import {
CROSS_CHAIN_SEAPORT_V1_5_ADDRESS,
CROSS_CHAIN_SEAPORT_V1_6_ADDRESS,
OPENSEA_CONDUIT_KEY,
} from "@opensea/seaport-js/lib/constants";
Expand Down Expand Up @@ -74,8 +73,6 @@ export class OpenSeaSDK {
public provider: JsonRpcProvider;
/** Seaport v1.6 client @see {@link https://github.com/ProjectOpenSea/seaport-js} */
public seaport_v1_6: Seaport;
/** Seaport v1.5 client @see {@link https://github.com/ProjectOpenSea/seaport-js} */
public seaport_v1_5: Seaport;
/** Logger function to use when debugging */
public logger: (arg: string) => void;
/** API instance */
Expand Down Expand Up @@ -110,15 +107,6 @@ export class OpenSeaSDK {
signerOrProvider) as JsonRpcProvider;
this._signerOrProvider = signerOrProvider ?? this.provider;

// eslint-disable-next-line @typescript-eslint/no-explicit-any
this.seaport_v1_5 = new Seaport(this._signerOrProvider as any, {
overrides: {
contractAddress: CROSS_CHAIN_SEAPORT_V1_5_ADDRESS,
seaportVersion: "1.5",
defaultConduitKey: OPENSEA_CONDUIT_KEY,
},
});

// eslint-disable-next-line @typescript-eslint/no-explicit-any
this.seaport_v1_6 = new Seaport(this._signerOrProvider as any, {
overrides: { defaultConduitKey: OPENSEA_CONDUIT_KEY },
Expand Down Expand Up @@ -840,8 +828,6 @@ export class OpenSeaSDK {
private getSeaport(protocolAddress: string): Seaport {
const checksummedProtocolAddress = ethers.getAddress(protocolAddress);
switch (checksummedProtocolAddress) {
case CROSS_CHAIN_SEAPORT_V1_5_ADDRESS:
return this.seaport_v1_5;
case CROSS_CHAIN_SEAPORT_V1_6_ADDRESS:
return this.seaport_v1_6;
default:
Expand Down Expand Up @@ -926,8 +912,6 @@ export class OpenSeaSDK {
switch (protocolAddressChecksummed) {
case CROSS_CHAIN_SEAPORT_V1_6_ADDRESS:
return "1.6";
case CROSS_CHAIN_SEAPORT_V1_5_ADDRESS:
return "1.5";
default:
throw new Error("Unknown or unsupported protocol address");
}
Expand Down
8 changes: 3 additions & 5 deletions src/utils/utils.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import {
CROSS_CHAIN_SEAPORT_V1_5_ADDRESS,
CROSS_CHAIN_SEAPORT_V1_6_ADDRESS,
ItemType,
} from "@opensea/seaport-js/lib/constants";
Expand Down Expand Up @@ -376,10 +375,9 @@ export const isTestChain = (chain: Chain): boolean => {
*/
export const isValidProtocol = (protocolAddress: string): boolean => {
const checkSumAddress = ethers.getAddress(protocolAddress);
const validProtocolAddresses = [
CROSS_CHAIN_SEAPORT_V1_6_ADDRESS,
CROSS_CHAIN_SEAPORT_V1_5_ADDRESS,
].map((address) => ethers.getAddress(address));
const validProtocolAddresses = [CROSS_CHAIN_SEAPORT_V1_6_ADDRESS].map(
(address) => ethers.getAddress(address),
);
return validProtocolAddresses.includes(checkSumAddress);
};

Expand Down
2 changes: 1 addition & 1 deletion test/utils.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ suite("Utils: utils", () => {

// Mapping of [address, isValid]
const addressesToCheck: [string, boolean][] = [
[CROSS_CHAIN_SEAPORT_V1_5_ADDRESS, true],
[CROSS_CHAIN_SEAPORT_V1_6_ADDRESS, true],
[CROSS_CHAIN_SEAPORT_V1_5_ADDRESS, false], // 1.5 is no longer supported
[randomAddress, false],
];

Expand Down
Loading