Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement on-demand streaming #81

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Implement on-demand streaming #81

wants to merge 21 commits into from

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Mar 1, 2025

Fixes #74

Now that we're unblocked on the streaming issues, we can finally add on-demand streaming here.

To do

  • Update useAsyncIterable to properly support cancellation
  • Add DisplayStream
    • Use it in DisplayGrid
  • Add useModelStream and useStream hooks
    • Investigate whether we'd want to make useStream generic (this would trade convenience for fake type-safety, not sure if we would actually want that or rather force the user to cast to make things more explicit)
  • Stream in monitoring view
  • Stream in resource browser

fwcd added 21 commits October 10, 2024 05:07
@fwcd
Experimentally stream displays on demand
58a19fb
@fwcd
Fix rerender loop by using memo for filteredUsers in DisplayGrid
7986a4a
@fwcd
Clear user model when clicked
39179d8
@fwcd
Sort models in grid again
721a0b1
@fwcd
Log received models
1d695b8
@fwcd
Handle out-of-order streamed models
62a65df
@fwcd
Factor out DisplayStream
2bacdae
@fwcd
Remove some no longer needed defensive coding from DisplayStream
ba6e161 
Since the new component automatically remounts when the username
changes, we don't need to guard against asynchronously receiving frames
for some old username when switching route.
@fwcd
Race 'next' promise in useAsyncIterable to handle cancellation
3c04fd4 
Not sure whether this is safe though...
@fwcd
Merge branch 'stream-on-demand-v2-race-cancellation' into stream-on-d…
7e675f6 
…emand-v3
@fwcd
Fix and implement streaming via model context
f3f5186
@fwcd
Simplify cancellation logic
a0f86e6
@fwcd
Add assertion utility module
a61cfe3
@fwcd
Add some assertions
7388a6c
@fwcd
Fix an annoying bug around async iterables that return something
5d2ab2e 
This caused arrays to end up in strange places, because
mergeAsyncIterable happened to return an array.
@fwcd
Revert "Add some assertions"
924f5c3 
This reverts commit 7388a6c.
@fwcd
Make sure all users show up in the models
bab0060
@fwcd
Insert missing users in one update
ffd7c23
@fwcd
Abstract out useModelStream hook
7f90dfd
@fwcd
Add general useStream hook
eaca9ec
@fwcd
Merge branch 'main' into stream-on-demand-v3
07a6e12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add useStream hook for on-demand streaming
1 participant
@fwcd