Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix monitoring cards layout on smaller devices #71

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Fix monitoring cards layout on smaller devices #71

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
209c33f
Require 2xl for row layout in monitor view
fwcd Feb 27, 2025
cb459b3
Remove todo note
fwcd Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/screens/home/admin/MonitorView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,8 @@ export function MonitorView() {
[flatRoomMetrics, roomMetrics, focusedRoom]
);

// TODO: more appealing UI (maybe tables, inputs or custom stuff?)
const isColumnLayout = breakpoint < Breakpoint.TwoXl;

return (
<HomeContent
title="Monitoring"
Expand All @@ -258,12 +259,12 @@ export function MonitorView() {
</Button>
}
>
<div className="flex flex-col space-y-4 md:flex-row h-full">
<div className="flex flex-col space-y-4 2xl:flex-row h-full">
<div
ref={wrapperRef}
className="grow flex flex-row justify-center h-full"
>
<div className={isCompact ? '' : 'absolute'}>
<div className={isColumnLayout ? '' : 'absolute'}>
<Display
width={width}
frame={frame}
Expand All @@ -275,7 +276,9 @@ export function MonitorView() {
</div>
</div>
<div
className={isCompact ? '' : 'flex flex-row justify-end grow-0 w-1/3'}
className={
isColumnLayout ? '' : 'flex flex-row justify-end grow-0 w-1/3'
}
>
<MonitorInspector
criterion={criterion}
Expand Down