Skip to content

Adjust margin in sidebar to center elements #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adjust margin in sidebar to center elements #202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/styles/theme.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ h4:focus > a > span.icon {

li {
margin: var(--size-2) 0;
margin-left: 20%;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a global style, and so changing this here is potentially going to change <li> globally, which we can see already happening in the header
Screenshot 2025-03-31 at 2 41 00 PM

I think for this kind of change, it should be happening in the styles for the table of contents component specifically
https://github.com/ProjectEvergreen/www.greenwoodjs.dev/blob/main/src/components/table-of-contents/table-of-contents.module.css

Also, for the actual value of whatever we end up going with, we should try and use open-props styles whenever possible as that is the style library we are using in this project.

I suppose we could consider seeing if this li selector is even needed here, or if it's just for markdown content, but that's probably something to work out in a standalone issue / PR

}

.page-content {
Expand Down