Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/issue 126 migrate to shadowrootmode attribute #127

Merged
merged 1 commit into from
Dec 28, 2023
Merged

feature/issue 126 migrate to shadowrootmode attribute #127

merged 1 commit into from
Dec 28, 2023

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Dec 28, 2023 •
edited
Loading

Related Issue

resolves #126

Summary of Changes

  1. Find / replace all instances of shadowroot attribute with "new" spec compliant shadowrootmode
  2. Update documentation and test cases

Can confirm no more issues with this now enabled
Before
Screenshot 2023-12-28 at 3 47 49 PM

After
Screenshot 2023-12-28 at 3 47 27 PM

@thescientist13 thescientist13 added documentation Improvements or additions to documentation feature New feature or request labels Dec 28, 2023
@thescientist13 thescientist13 changed the title feature/issue 126 migrate to shadowrootmode attribute feature/issue 126 migrate to shadowrootmode attribute Dec 28, 2023
@thescientist13 thescientist13 merged commit 06309e3 into master Dec 28, 2023
11 checks passed
@thescientist13 thescientist13 deleted the feature/issue-126-adopt-shadowrootmode branch December 28, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support shadowrootmode attribute for declarative shadow DOM
1 participant
@thescientist13