Skip to content

Commit

Permalink
refactor and TODO comment for spec alignment
Browse files Browse the repository at this point in the history
  • Loading branch information
thescientist13 committed Feb 19, 2024
1 parent af531f8 commit 1e3b651
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions src/dom-shim.js
Original file line number Diff line number Diff line change
Expand Up @@ -129,15 +129,14 @@ class CustomElementsRegistry {
}

define(tagName, BaseClass) {
// TODO this should probably fail as per the spec...

Check warning on line 132 in src/dom-shim.js

View workflow job for this annotation

GitHub Actions / build (20)

Unexpected 'todo' comment: 'TODO this should probably fail as per...'

Check warning on line 132 in src/dom-shim.js

View workflow job for this annotation

GitHub Actions / build (20)

Unexpected ' TODO' comment: 'TODO this should probably fail as per...'

Check warning on line 132 in src/dom-shim.js

View workflow job for this annotation

GitHub Actions / build (18)

Unexpected 'todo' comment: 'TODO this should probably fail as per...'

Check warning on line 132 in src/dom-shim.js

View workflow job for this annotation

GitHub Actions / build (18)

Unexpected ' TODO' comment: 'TODO this should probably fail as per...'

Check warning on line 132 in src/dom-shim.js

View workflow job for this annotation

GitHub Actions / build (20)

Unexpected 'todo' comment: 'TODO this should probably fail as per...'

Check warning on line 132 in src/dom-shim.js

View workflow job for this annotation

GitHub Actions / build (20)

Unexpected ' TODO' comment: 'TODO this should probably fail as per...'

Check warning on line 132 in src/dom-shim.js

View workflow job for this annotation

GitHub Actions / build (18)

Unexpected 'todo' comment: 'TODO this should probably fail as per...'

Check warning on line 132 in src/dom-shim.js

View workflow job for this annotation

GitHub Actions / build (18)

Unexpected ' TODO' comment: 'TODO this should probably fail as per...'

Check warning on line 132 in src/dom-shim.js

View workflow job for this annotation

GitHub Actions / build (20)

Unexpected 'todo' comment: 'TODO this should probably fail as per...'

Check warning on line 132 in src/dom-shim.js

View workflow job for this annotation

GitHub Actions / build (20)

Unexpected ' TODO' comment: 'TODO this should probably fail as per...'

Check warning on line 132 in src/dom-shim.js

View workflow job for this annotation

GitHub Actions / build (20)

Unexpected 'todo' comment: 'TODO this should probably fail as per...'

Check warning on line 132 in src/dom-shim.js

View workflow job for this annotation

GitHub Actions / build (20)

Unexpected ' TODO' comment: 'TODO this should probably fail as per...'

Check warning on line 132 in src/dom-shim.js

View workflow job for this annotation

GitHub Actions / build (18)

Unexpected 'todo' comment: 'TODO this should probably fail as per...'

Check warning on line 132 in src/dom-shim.js

View workflow job for this annotation

GitHub Actions / build (18)

Unexpected ' TODO' comment: 'TODO this should probably fail as per...'

Check warning on line 132 in src/dom-shim.js

View workflow job for this annotation

GitHub Actions / build (18)

Unexpected 'todo' comment: 'TODO this should probably fail as per...'

Check warning on line 132 in src/dom-shim.js

View workflow job for this annotation

GitHub Actions / build (18)

Unexpected ' TODO' comment: 'TODO this should probably fail as per...'
// e.g. if(this.customElementsRegistry.set(tagName))
// https://github.com/ProjectEvergreen/wcc/discussions/145
this.customElementsRegistry.set(tagName, BaseClass);
}

get(tagName) {
if (this.customElementsRegistry.get(tagName)) {
return this.customElementsRegistry.get(tagName);
} else {
// uh oh...
}
return this.customElementsRegistry.get(tagName);
}
}

Expand Down

0 comments on commit 1e3b651

Please sign in to comment.