fixed absolute path config bug and improved workspace related specs #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
bug
thescientist13
commented
May 16, 2019
| @@ -17,7 +17,7 @@ module.exports = { | |||
| checkCoverage: true, | |||
|
|
|||
| statements: 85, | |||
| branches: 65, | |||
| branches: 70, | |||
thescientist13
commented
May 16, 2019
packages/cli/lib/config.js
Outdated
| // use the users provided path | ||
| customConfig.workspace = workspace; | ||
| } | ||
|
|
||
| if (!fs.existsSync(workspace)) { |
There was a problem hiding this comment.
thinking about changing this line from this
if (!fs.existsSync(workspace)) {to this
if (!fs.existsSync(customConfig.workspace)) {this will make just help ensure we're validating against our own internal logic.
edit: nvm I see you left the ability to use relative still. |
hutchgrant
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #81
Summary of Changes
Looks like our existing custom workspace wasn't robust enough, and failed to test that if there was actually any user content in the directory, it would actually get built.