Fix test async and teardown #77
Conversation
| setup = new TestBed(); | ||
| context = setup.setupTestBed(__dirname); | ||
| this.context = setup.setupTestBed(__dirname); |
There was a problem hiding this comment.
Confused about the switch to this though. What is this in this context anyway, in the middle of a describe block?
Maybe it's needed to fix this, if so, could you just expand? My only concern is just making sure all these tests remain as isolated as possible.
There was a problem hiding this comment.
https://github.com/mochajs/mocha/wiki/Shared-Behaviours
If you try to use the context within the describe and not part of this, while using context as a parameter for smokeTests and each test, you will receive the following
6) Build Greenwood With:
Default Greenwood Configuration and Workspace
Running Smoke Tests: Default Greenwood Configuration and Workspace
404 (Not Found) page
"before each" hook for "should have a <script> tag in the <body>":
TypeError: Cannot read property 'publicDir' of undefined
The reason for that is, when the variable context is initialized in the before() via setup() it's not assigned to the describe's context at all. Because the context.publicDir, isn't working in the smokeTests([], context, label) after. That or we're not accessing the right context, from the child describe, when we're using it as a parameter.
Within each before, it, and after, you can share the same this variables(as long as you don't use arrow functions, test using one you'll see it breaks it).
There was a problem hiding this comment.
it has something to do with all our nested describes and shared tests. In any event, yes it's required.
Using context instead of this.context, running
describe('Build Greenwood With: ', function() {
const LABEL = 'Default Greenwood Configuration and Workspace';
let setup;
let context;
before(function() {
setup = new TestBed();
context = setup.setupTestBed(__dirname);
});
describe(LABEL, function() {
before(async function() {
await setup.runGreenwoodCommand('build');
});
runSmokeTest(['public', 'index', 'not-found', 'hello'], context, LABEL);
});
after(function() {
setup.teardownTestBed();
});
});with smoke-test.js
// TOOD need to find a good Promise based way to call setup.teardownTestBed() after all tests are run
// right now, test files are left over after tests are run, but are cleaned up before each test run
module.exports = runSmokeTest = async function(testCases, context, label) {
console.log(context);
}will output undefined.
Also, if you're thinking of putting that runSmokeTest() within a nested test how it was previously, that will also not work because of the teardown. Granted, the context variable will output correctly, but everything else will fail because of teardown.
it('run smoke test', function() {
runSmokeTest(['public', 'index', 'not-found', 'hello'], context, LABEL);
});output:
1) Running Smoke Tests: Default Greenwood Configuration and Workspace
Public Directory Generated Output
should create a public directory:
AssertionError: expected false to be true
+ expected - actual
-false
+true
at Context.<anonymous> (test/cli/smoke-test.js:11:55)That error x7. Without teardown in after() yes, this runs correctly.
Trust me, it took a lot of fiddling to get shared tests working.
|
|
|
Not sure if you've seen inception, but running through these 3 PRs now feels like the setting up the kicks in the final act of the movie, lol |
thescientist13
merged commit c1bfa08
into
technical/issue-56-organize-tests-smoke-test-refactor
* integrating smoke tests * full smoke test integration * cleanup * fix linting * improve error message * Fix test async and teardown (#77) * fix: removed smoke test promises, implemented shared context using this * fix: remove TODO
* WIP tests * all happy paths for config * WIP refactoring setup to use cwd context * WIP refactoring * more cases working * cleanup * formatting * new nested case * more cases * page template case * clean up tests * config workspace case * smoke testing and creating test bed * using more smoke testing * added testing for deeper 404 and index testing * remove eslint * watch mode * code coverage and reporting * reuse test bed * playing around with smoke tests * cleanup * delete fixtures * remove commented out code * increase test timeout * one minute? * build config error handling * relax smoke test content testing * fix spec using hash * better test and build output cleanup * Technical/issue 56 organize tests smoke test refactor (#75) * integrating smoke tests * full smoke test integration * cleanup * fix linting * improve error message * Fix test async and teardown (#77) * fix: removed smoke test promises, implemented shared context using this * fix: remove TODO
hutchgrant
deleted the
technical/issue-56-organize-tests-fix-async-teardown
branch
Related Issue
#56
Summary of Changes