Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better handling for pages with index in their name #462

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Dec 31, 2020

Related Issue

resolves #455

Will track in Trello for post 1.0 release some ways to refactor / clean up a lot of this repeated page look up logic, like we have in the markdown / HTML transforms, as well as in the graph lifecycle. Maybe some sort of shared utility so we can avoid duplications, or at the very least, maybe this is a case to merge markdown and HTML transforms?

Summary of Changes

  1. Better checking for pages that may include index as part of the page name (non "destructive" approach)
  2. Enabled tests to verify the same
  3. Although will be deprecated, Plugins -> Index Hooks docs are now working again

Screen Shot 2020-12-31 at 1 43 09 PM

@thescientist13 thescientist13 added bug Something isn't working website Tasks related to the projects website / documentation CLI labels Dec 31, 2020
@thescientist13 thescientist13 merged commit a4df944 into release/0.10.0 Jan 7, 2021
@thescientist13 thescientist13 deleted the bug/issue-455-fix-index-page-naming-collision-restore-plugins-index-page branch January 7, 2021 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI website Tasks related to the projects website / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant