-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve multiple <slot> elements rendering on the home page #454
Merged
thescientist13
merged 9 commits into
release/0.10.0
from
bug/issue-433-resolve-slot-double-rendering
Jan 23, 2021
+69
−106
Merged
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ee14071
initial WIP to resolve the issue
thescientist13 6e04044
example code cleanup
thescientist13 9b055a3
supplemental documentation for Shadow DOM and slot usage
thescientist13 64f3f23
restore card padding
aholtzman 06e0880
fix padding, revert slot to direct decendent of host
aholtzman fe14757
remove extra dependency
thescientist13 4b4028a
home page card style tweaks
thescientist13 8457ec9
Merge branch 'release/0.10.0' into bug/issue-433-resolve-slot-double-…
thescientist13 5b0059f
Merge branch 'release/0.10.0' into bug/issue-433-resolve-slot-double-…
thescientist13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,65 +1,37 @@ | ||
| :host { | ||
|
|
||
| & .card { | ||
| padding: 2.5rem; | ||
| position: relative; | ||
| display: flex; | ||
| flex-direction: column; | ||
| min-width: 0; | ||
| word-wrap: break-word; | ||
| background-color: #fff; | ||
| background-clip: initial; | ||
| text-align: center; | ||
|
|
||
| @media(max-width:768px) { | ||
| padding:0; | ||
| } | ||
|
|
||
| & .body { | ||
| padding:10px; | ||
| position: relative; | ||
| display: flex; | ||
| flex-direction: column; | ||
| min-width: 0; | ||
| word-wrap: break-word; | ||
| background-color: #fff; | ||
| background-clip: initial; | ||
| text-align: center; | ||
|
|
||
| @media (max-width: 768px) { | ||
| .gwd-card { | ||
| padding: 0; | ||
| } | ||
| } | ||
|
|
||
|
|
||
| & .card-xs { | ||
| margin: 0.25rem; | ||
| flex: 1 1 16.666%; | ||
| max-width: 250px; | ||
|
|
||
| @media (max-width: 1024px) { | ||
| max-width: 100%; | ||
| } | ||
| } | ||
| & .card-sm { | ||
| margin: 0.25rem; | ||
| flex: 1 1 25%; | ||
| max-width: 380px; | ||
|
|
||
| @media (max-width: 1024px) { | ||
| max-width: 100%; | ||
| } | ||
| } | ||
| & .card-md { | ||
| & slot { | ||
| padding: 10px; | ||
| margin: 0.25rem; | ||
| flex: 1 1 33.333%; | ||
| max-width: 450px; | ||
|
|
||
| @media (max-width: 1024px) { | ||
| max-width: 100%; | ||
| } | ||
| } | ||
| & .card-full { | ||
| margin: 0.25rem; | ||
| flex: 1 1 33.333%; | ||
|
|
||
| & .gwd-card { | ||
| padding: 1.25rem; | ||
| } | ||
|
|
||
| & .card-img-top { | ||
| background-size: cover; | ||
| background-position-x: center; | ||
| background-position-y: center; | ||
|
|
||
| & img { | ||
| width: 100%; | ||
| max-width: 200px; | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately this wont work for
yarn servebecause this moves the<slot>away from being a direct descendent of the:host😞