Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/issue 276 update dependencies #398

Merged
merged 2 commits into from
Jul 25, 2020

Conversation

hutchgrant
Copy link
Member

Related Issue

Resolves #276

Summary of Changes

  • update package.json
  • update cli/package.json
  • update lockfile

Copy link
Member

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I don't see where is this actually updating browserslist? It's just updating babel?

@thescientist13 thescientist13 added help wanted Extra attention is needed dependencies Pull requests that update a dependency file labels Jul 22, 2020
@hutchgrant
Copy link
Member Author

hutchgrant commented Jul 22, 2020

It's not that simple unfortunately. I tried updating just babel, just postcss-preset-env and neither was the single cause of the bug. yarn upgrade everything and bug was gone. caniuse-lite is a dependency of multiple packages which are dependencies of other packages.

Copy link
Member

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see what you mean now. Yeah, from the message it suggested yarn upgrade should solve it. Looks good in GitHub Actions. 👌
Screen Shot 2020-07-22 at 8 16 44 PM

Interesting that It was upgrading @babel/preset-env specifically that made it work, not browserslist. TIL

@thescientist13 thescientist13 removed the help wanted Extra attention is needed label Jul 23, 2020
@thescientist13 thescientist13 self-assigned this Jul 23, 2020
@thescientist13 thescientist13 merged commit f3bb3f7 into master Jul 25, 2020
@thescientist13 thescientist13 deleted the task/issue-276-update-browserslist branch July 25, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update browserslist version
2 participants