Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/issue 322 remove need for MDIMPORT, rename MYROUTES #387

Merged
merged 10 commits into from
Jul 22, 2020

Conversation

hutchgrant
Copy link
Member

@hutchgrant hutchgrant commented Jul 12, 2020

Related Issue

Resolves #322

Summary of Changes

  • Removes need for MDIMPORT, updates scaffold to insert md file path automatically beneath a lit-element import
  • Renames MYROUTES to just <routes></routes>

TODO

  • update layouts.md docs

@thescientist13 thescientist13 self-requested a review July 19, 2020 14:16
Copy link
Member

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty cool! But seems that it assumes hard dependency on lit-element? What if someone wasn't using it, like just normal HTMLElement or other base class library?

Is it just because a last import statement is needed to be known? Seems like there are safer ways for that, or maybe just start at the beginning of the file and make it the first one?

@thescientist13 thescientist13 added CLI documentation Greenwood specific docs enhancement Improve something existing (e.g. no docs, new APIs, etc) help wanted Extra attention is needed labels Jul 19, 2020
@hutchgrant
Copy link
Member Author

I suppose that's a simpler and more library agnostic solution to simply put it on the first line.

Copy link
Member

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hutchgrant
Looks like this will need a merge conflict resolution post merging in #382

@hutchgrant
Copy link
Member Author

Was going to warn you about it. Glad you noticed. Will fix.

…ectEvergreen/greenwood into task/issue-322-remove-magic-strings
@thescientist13 thescientist13 merged commit 4e12b64 into master Jul 22, 2020
@thescientist13 thescientist13 deleted the task/issue-322-remove-magic-strings branch July 22, 2020 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking CLI documentation Greenwood specific docs enhancement Improve something existing (e.g. no docs, new APIs, etc) help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove "magic" strings MDIMPORT / MYROUTES
2 participants