-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/issue 322 remove need for MDIMPORT, rename MYROUTES #387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty cool! But seems that it assumes hard dependency on lit-element? What if someone wasn't using it, like just normal HTMLElement
or other base class library?
Is it just because a last import
statement is needed to be known? Seems like there are safer ways for that, or maybe just start at the beginning of the file and make it the first one?
I suppose that's a simpler and more library agnostic solution to simply put it on the first line. |
…into task/issue-322-remove-magic-strings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hutchgrant
Looks like this will need a merge conflict resolution post merging in #382
Was going to warn you about it. Glad you noticed. Will fix. |
…ask/issue-322-remove-magic-strings
…ectEvergreen/greenwood into task/issue-322-remove-magic-strings
Related Issue
Resolves #322
Summary of Changes
MYROUTES
to just<routes></routes>
TODO
update layouts.md docs