-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/issue 128 fix undefined link title setting #308
Bug/issue 128 fix undefined link title setting #308
Conversation
The bug is only present during my testing when you load page with an anchor tag in the link. In the process of trying to replicate this I found another bug. This link will scroll the page down when it should not. This behaviour is present on all pages. edit: added issue #309 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like part of the issue is that Netlify is adding a trailing /
, which is partially interfering with the matching logic, hence why sometimes a currentPage
isn't found.
Might be worth making an issue for this, maybe thinking of a way to inject some sort of `CURRENT_PAGE_ constant / environment variable or something? Or ideally getting it from the graph somehow.
Maybe doable as part of #305 or #299 ? Or maybe just needs it own issue.
Made a formal issue for this and putting into the next project to find a proper solution for this (the trailing |
Also seems related to #310. |
Related Issue
as part of #128 / #300 , fixes an immediate error now identified as #331

Summary of Changes
currentPage
is found, but not sure if a logic issue?