Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/issue 128 fix undefined link title setting #308

Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Mar 23, 2020

Related Issue

as part of #128 / #300 , fixes an immediate error now identified as #331
Screen Shot 2020-03-22 at 8 16 57 PM

Summary of Changes

  1. fallback to make sure currentPage is found, but not sure if a logic issue?

@thescientist13 thescientist13 added the bug Something isn't working label Mar 23, 2020
@thescientist13 thescientist13 changed the base branch from master to release/0.5.0 March 23, 2020 00:30
@hutchgrant
Copy link
Member

hutchgrant commented Mar 26, 2020

The bug is only present during my testing when you load page with an anchor tag in the link.

In the process of trying to replicate this I found another bug.

This link will scroll the page down when it should not. This behaviour is present on all pages.

edit: added issue #309

Copy link
Member Author

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like part of the issue is that Netlify is adding a trailing /, which is partially interfering with the matching logic, hence why sometimes a currentPage isn't found.

Might be worth making an issue for this, maybe thinking of a way to inject some sort of `CURRENT_PAGE_ constant / environment variable or something? Or ideally getting it from the graph somehow.

Maybe doable as part of #305 or #299 ? Or maybe just needs it own issue.

@thescientist13
Copy link
Member Author

Made a formal issue for this and putting into the next project to find a proper solution for this (the trailing /)

@thescientist13
Copy link
Member Author

Also seems related to #310.

@thescientist13 thescientist13 added the v0.5.0 Data w/ GraphQL label Apr 22, 2020
@thescientist13 thescientist13 merged commit ff3f170 into release/0.5.0 Apr 22, 2020
@thescientist13 thescientist13 deleted the bug/issue-128-fix-undefined-link-title-setting branch April 22, 2020 22:21
@thescientist13 thescientist13 mentioned this pull request Apr 22, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI v0.5.0 Data w/ GraphQL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants