-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show stats and progress #261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... looks like the ProgressPlugin
doesn't play nicely with our unit tests? (commenting it out locally makes things happy).
I wonder if it's the equivalent of #84 but for build
? 🤔
Maybe I should resolve
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OH! Should add webpack-bundle-analyzer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what's interesting looking at the build failure is that webpack is still compiling in the failure cases, even though the config lifecycle should have rejected that Promise already..
So seems like that part of the chain isn't working as expected. 🤔
Ok, so I made sure the
So this means our spec will pass (good) but We could not throw error code 1, but then when actually running edit, oh wait, this might be cause of code coverage since i was using |
Yeah, still seems to be something with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to close this for now and move the issue itself to the next project and we can tackle this along with #47
Related Issue
resolves #260
Now output looks like this
Summary of Changes
webpack.ProgressPlugin
*!. Add webpack-bundle-analyzer ?