Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error info: BACD-0007 has 2 discs actually #208

Merged
merged 5 commits into from
Dec 8, 2024

Conversation

LacLic
Copy link
Contributor

@LacLic LacLic commented Feb 27, 2024

Screenshot 2024-02-27 115915

@snylonue
Copy link
Contributor

https://beta.musicbrainz.org/release-group/6ad802e2-593a-40e6-86e2-6d9da59678fa
之前加的时候选了 Digital Media 那个

@LacLic
Copy link
Contributor Author

LacLic commented Feb 27, 2024

https://beta.musicbrainz.org/release-group/6ad802e2-593a-40e6-86e2-6d9da59678fa

之前加的时候选了 Digital Media 那个

但是感觉按道理来说,也许应该以实体 cd 为准…?

以及同类型的其他 CD (vol.1, vol.2, vol.4) 都是 2 Discs

album/BACD-0007.toml Outdated Show resolved Hide resolved
album/BACD-0007.toml Outdated Show resolved Hide resolved
album/BACD-0007.toml Show resolved Hide resolved
@Yesterday17
Copy link
Member

我怎么一直没有把 review 提交出去草

@LacLic
Copy link
Contributor Author

LacLic commented Oct 20, 2024

草,我都忘了 pull request 还开着,还在把东西往那个 branch 上 commit,是不是爆邮件了
我先把 BACD-0007 相关的东西 pick 出来一下

@LacLic
Copy link
Contributor Author

LacLic commented Oct 20, 2024

已处理 reviews,连带之前的另一份 cd 也处理好了

@tuzi3040 tuzi3040 enabled auto-merge December 8, 2024 13:59
@tuzi3040 tuzi3040 added this pull request to the merge queue Dec 8, 2024
Merged via the queue into ProjectAnni:master with commit cdd1e87 Dec 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants