Merge pull request #394 from dontub/replace-deprecated-setItem-call

Replace call of deprecated method `CRM_Core_BAO_Setting::setItem()`
Project60 · Jan 17, 2025 · 74b0b2b · 74b0b2b
2 parents 57ea854 + ea14efc
commit 74b0b2b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/CRM/Banking/Form/AccountsTab.php b/CRM/Banking/Form/AccountsTab.php
@@ -199,10 +199,10 @@ function postProcess() {
 
     // save presets
     if (!empty($values['reference_type'])) {
-        CRM_Core_BAO_Setting::setItem($values['reference_type'], 'CiviBanking', 'account.default_reference_id');
+        Civi::settings()->set('account.default_reference_id', $values['reference_type']);
     }
     if (!empty($values['country'])) {
-        CRM_Core_BAO_Setting::setItem($values['country'], 'CiviBanking', 'account.default_country');
+        Civi::settings()->set('account.default_country', $values['country']);
     }
 
     // create bank account

diff --git a/CRM/Banking/Upgrader.php b/CRM/Banking/Upgrader.php
@@ -48,7 +48,7 @@ public function upgrade_0610() {
    * @return TRUE on success
    */
   public function upgrade_0611() {
-    CRM_Core_BAO_Setting::setItem(false, 'org.project60.banking', 'new_ui');
+    Civi::settings()->set('new_ui', false);
 
     // Update order of the option group banking_tx_status.
     $statusApi = civicrm_api3('OptionValue', 'get', array('option_group_id' => 'civicrm_banking.bank_tx_status', 'options' => array('limit' => 0)));

diff --git a/banking.php b/banking.php
@@ -52,7 +52,7 @@ function banking_civicrm_install() {
   banking_civicrm_install_options(_banking_options());
 
   // Set the bank account reference probability to 100%.
-  CRM_Core_BAO_Setting::setItem('1.0', 'CiviBanking', 'reference_matching_probability');
+  Civi::settings()->set('reference_matching_probability', 1.0);
 
   return _banking_civix_civicrm_install();
 }