Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Conan revisions correctly #6828

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Pin Conan revisions correctly #6828

merged 4 commits into from
Mar 15, 2024

Conversation

mjjbell
Copy link
Member

@mjjbell mjjbell commented Mar 10, 2024

Issue

Conan dependencies are not pinned correctly. This means we're pulling in a newer onetbb recipe that no longer has a shared library option.

onetbb/2021.3.0: Downloaded recipe revision 507ec17cbd51a84167e143b20d170eea
ERROR: onetbb/2021.3.0: option 'shared' doesn't exist
Possible options are ['tbbbind']

Following other examples of how to pin revisions with cmake for conan v1, we correctly pin the expected revisions.

Longer term we should look into

  • upgrading to conan v2
  • defining the conan config separately from CMakeLists.txt
  • understanding the need for disabling onetbb shared library support

but for the purposes of reviving CI, this will be sufficient.

Requirements / Relations

Help to restore the project as discussed in #6778

@mjjbell mjjbell changed the title Pin Conan onetbb version to shared support Pin Conan revisions correctly Mar 10, 2024
@mjjbell mjjbell force-pushed the mbell/fix_build branch 3 times, most recently from 4b6ccf6 to ad31cb8 Compare March 10, 2024 23:49
Conan dependencies are not pinned correctly. This means we're
pulling in a newer onetbb recipe that no longer has a shared
library option.

Following other examples of how to pin revisions with cmake
for conan v1, we correctly pin the expected revisions.

Longer term we should look into
- upgrading to conan v2
- defining the conan config separately from cmakelists.txt
- understanding the need for disabling onetbb shared library support

but for the purposes of reviving CI, this will be sufficient.
@mjjbell mjjbell force-pushed the mbell/fix_build branch 5 times, most recently from a2752aa to 7eb583f Compare March 14, 2024 22:53
@mjjbell mjjbell merged commit e219eb9 into master Mar 15, 2024
20 checks passed
@mjjbell mjjbell deleted the mbell/fix_build branch March 15, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants