-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tcia prostatex model notebook #1852
base: main
Are you sure you want to change the base?
Update tcia prostatex model notebook #1852
Conversation
This reverts commit 00f3362.
Fixed some dependency issues related to itkwidgets that were preventing the notebook from running.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Updated with the guidance provided in Project-MONAI#1852.
Looks the notebook still can not pass the premerge. |
DCO Remediation Commit for Justin Kirby <[email protected]> I, Justin Kirby <[email protected]>, hereby add my Signed-off-by to this commit: 00f3362 I, Justin Kirby <[email protected]>, hereby add my Signed-off-by to this commit: 6e36c64 I, Justin Kirby <[email protected]>, hereby add my Signed-off-by to this commit: f3d172e I, Justin Kirby <[email protected]>, hereby add my Signed-off-by to this commit: 6fc1435 Signed-off-by: Justin Kirby <[email protected]>
I'm not sure what the issue is. I can run the notebook end to end in both Colab and Sagemaker Studio Lab without any problems other than these reported dependency issues that don't seem to affect the rest of the notebook:
|
Yes, but the main reason here is that it hangs at specific cell since the whole notebook don't take over 6 hours to run. |
Fix pep8/premerge errors. Signed-off-by: Justin Kirby <[email protected]>
I just saw this in the middle of the report:
I don't understand why it's complaining about sys not being used. I guess it doesn't pick it up properly when calling it like this for all the installations?
I changed it back to just say "python" instead and removed the extra blank lines. |
I'm out of ideas in terms of fixing whatever is still causing this last check to fail. |
Can you try fix the version to 1.0a23? From what I tested last time, I find this version will not hang. But the latest version will hang. |
Removing screenshots of viewers to see if that fixes pre-merge checks. Signed-off-by: Justin Kirby <[email protected]>
That was already part of the requested changes. It's trying to use 1.0a53 in the most recent commits:
I tried removing the image ouputs from the imjoy plugin to see if maybe that was the issue. |
I attempted to run this notebook on a headless machine that we have for CICD. I found that the I also found that |
Description
Fixed dependency issues with itkwidgets