Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ValueError in maisi_train_controlnet_tutorial.ipynb #1839

Merged
merged 22 commits into from
Sep 25, 2024
Merged

Fix ValueError in maisi_train_controlnet_tutorial.ipynb #1839

merged 22 commits into from
Sep 25, 2024

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Sep 23, 2024 •
edited
Loading

Fixes #1838

Description

  • Upload to avoid torch.cuda deprecated error from GradScaler and autocast.
  • Update to remove file unclose error.
  • Update dim to avoid value error in controlnet tutorial.
  • Add multi-gpu check to avoid dist warning.

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

@KumoLiu
fix Project-MONAI#1838
554fd51 
Signed-off-by: YunLiu <[email protected]>
@KumoLiu
minor fix
e75e708 
Signed-off-by: YunLiu <[email protected]>
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@KumoLiu
minor fix
1cd42ab 
Signed-off-by: YunLiu <[email protected]>
@KumoLiu KumoLiu marked this pull request as draft September 23, 2024 10:53
@KumoLiu KumoLiu marked this pull request as ready for review September 24, 2024 03:14
KumoLiu and others added 9 commits September 24, 2024 11:48
@KumoLiu
address comments
db2d15e 
Signed-off-by: YunLiu <[email protected]>
@KumoLiu
Merge remote-tracking branch 'yliu/fix-controlnet' into fix-controlnet
555fb13
@KumoLiu
minor fix
ec1c42c 
Signed-off-by: YunLiu <[email protected]>
@KumoLiu
minor fix
f46840d 
Signed-off-by: YunLiu <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
5d35472 
for more information, see https://pre-commit.ci
@KumoLiu
Revert "minor fix"
4c601dc 
This reverts commit ec1c42c.
@KumoLiu
Merge branch 'fix-controlnet' of https://github.com/KumoLiu/tutorials …
75e2b8c 
…into fix-controlnet
@KumoLiu
revert active change
7305278 
Signed-off-by: YunLiu <[email protected]>
@KumoLiu
minor fix
620db88 
DCO Remediation Commit for YunLiu <[email protected]>

I, YunLiu <[email protected]>, hereby add my Signed-off-by to this commit: 4c601dc

Signed-off-by: YunLiu <[email protected]>
@dongyang0122
Copy link
Collaborator

dongyang0122 commented Sep 24, 2024 •
edited
Loading

It is better to have someone review the file.
active_learning/liver_tumor_al/active_learning.py

Since it is not related to MAISI. Thanks.

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Sep 24, 2024

It is better to have someone review the file. active_learning/liver_tumor_al/active_learning.py

Since it is not related to MAISI. Thanks.

Hi @dongyang0122, I have reverted the change related to active learning in this pr and will create another to make the change. Sorry for confusion.

guopengf
guopengf approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@guopengf guopengf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongyang0122
Copy link
Collaborator

It is better to have someone review the file. active_learning/liver_tumor_al/active_learning.py
Since it is not related to MAISI. Thanks.

Hi @dongyang0122, I have reverted the change related to active learning in this pr and will create another to make the change. Sorry for confusion.

All look good to me. Thank you.

@KumoLiu KumoLiu enabled auto-merge (squash) September 25, 2024 14:43
@KumoLiu KumoLiu merged commit 203a999 into Project-MONAI:main Sep 25, 2024
6 checks passed
@KumoLiu KumoLiu deleted the fix-controlnet branch September 26, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guopengf guopengf guopengf approved these changes

@dongyang0122 dongyang0122 dongyang0122 approved these changes

@Can-Zhao Can-Zhao Awaiting requested review from Can-Zhao

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ValueError in maisi_train_controlnet_tutorial.ipynb
4 participants
@KumoLiu @dongyang0122 @guopengf @Can-Zhao