Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove installation section in ldm2d and ldm3d readme #1821

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Sep 9, 2024

Remove installation section in ldm2d and ldm3d readme for two reasons:

  • No extra dependency need for this two tutorials for now.
  • The link will be broken if we don't include the README file from the upper level.

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@KumoLiu KumoLiu merged commit ae7496e into Project-MONAI:main Sep 10, 2024
6 checks passed
@KumoLiu KumoLiu deleted the update-readme branch September 10, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants