Ported all anomaly_detection tutorials #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Borges <[email protected]>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
…iafdez/tutorials into anomaly_detection_porting
for more information, see https://pre-commit.ci
Fixes Project-MONAI#1698 Fix typo and add 3d_image_transforms.ipnb test back (works well in 24.08) ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [ ] Avoid including large-size files in the PR. - [ ] Clean up long text outputs from code cells in the notebook. - [ ] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` Signed-off-by: YunLiu <[email protected]>
Try to use `ApplyTransformToPointsd` to update luna detection pipeline ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [ ] Avoid including large-size files in the PR. - [ ] Clean up long text outputs from code cells in the notebook. - [ ] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: YunLiu <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Mingxin Zheng <[email protected]>
Address some of Project-MONAI#1769. ### Description These are the 2D ~~and 3D~~ DDPM tutorials. I have run them again to verify they work. ~~The 2D ones are fine but the 3D tutorial keeps having mode collapse or some other issue resulting in bad results. Work is ongoing on this one.~~ I have left the 3D tutorial off since it's not training stably and needs some revamp to be a proper and useful tutorial for users. ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Avoid including large-size files in the PR. - [x] Clean up long text outputs from code cells in the notebook. - [x] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [x] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [x] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: Eric Kerfoot <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: YunLiu <[email protected]>
…iafdez/tutorials into anomaly_detection_porting
ericspod
reviewed
Sep 10, 2024
generation/anomaly_detection/2d_classifierfree_guidance_anomalydetection_tutorial.ipynb
Show resolved
Hide resolved
generation/anomaly_detection/2d_classifierfree_guidance_anomalydetection_tutorial.ipynb
Show resolved
Hide resolved
generation/anomaly_detection/2d_classifierfree_guidance_anomalydetection_tutorial.ipynb
Show resolved
Hide resolved
generation/anomaly_detection/2d_classifierfree_guidance_anomalydetection_tutorial.ipynb
Show resolved
Hide resolved
generation/anomaly_detection/anomalydetection_tutorial_classifier_guidance.ipynb
Show resolved
Hide resolved
|
Looks fine overall, there's a few minor things to fix to past the checks, and the DCO issue can be sorted with a remedial commit as instructed. |
20 tasks
…c.uk> I, Pedro Borges <[email protected]>, hereby add my Signed-off-by to this commit: 347a2c0 I, Pedro Borges <[email protected]>, hereby add my Signed-off-by to this commit: 74341ed I, Pedro Borges <[email protected]>, hereby add my Signed-off-by to this commit: 83b986d Signed-off-by: Pedro Borges <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Pedro Borges <[email protected]>
Signed-off-by: Pedro Borges <[email protected]>
ericspod
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ported all the anomaly detection tutorials.
Checks
./figurefolder./runner.sh -t <path to .ipynb file>