Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDPM Tutorials #1814

Merged
merged 14 commits into from
Sep 6, 2024
Merged

DDPM Tutorials #1814

merged 14 commits into from
Sep 6, 2024

Conversation

ericspod
Copy link
Member

@ericspod ericspod commented Sep 4, 2024

Address some of #1769.

Description

These are the 2D and 3D DDPM tutorials. I have run them again to verify they work. The 2D ones are fine but the 3D tutorial keeps having mode collapse or some other issue resulting in bad results. Work is ongoing on this one. I have left the 3D tutorial off since it's not training stably and needs some revamp to be a proper and useful tutorial for users.

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ericspod ericspod mentioned this pull request Sep 4, 2024
20 tasks
@ericspod ericspod marked this pull request as draft September 4, 2024 12:37
@ericspod
Copy link
Member Author

ericspod commented Sep 4, 2024

I'm still trying to get good results for the 3D example so not ready for review yet.

@ericspod
Copy link
Member Author

ericspod commented Sep 5, 2024

We're going to leave the 3D tutorial for later, it is not training stably at the moment and isn't a good examplar as a consequence.

Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
@ericspod ericspod marked this pull request as ready for review September 5, 2024 16:04
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Overall looks good to me. Minor comments inline.
And could you please also update the README file here: https://github.com/Project-MONAI/tutorials/blob/main/generation/README.md? Thanks!

Copy link
Contributor

@virginiafdez virginiafdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides existing comments, they look fine by me.

@ericspod ericspod enabled auto-merge (squash) September 6, 2024 10:56
@KumoLiu
Copy link
Contributor

KumoLiu commented Sep 6, 2024

Hi @ericspod, I just disable the auto-merge since the premerge-notebook is not a required one to test. Want to double-confirm. Perhaps we need set it to required test.

@ericspod
Copy link
Member Author

ericspod commented Sep 6, 2024

It should be required I'd say, unless there was some reason why notebooks would fail but still be mergable.

@KumoLiu
Copy link
Contributor

KumoLiu commented Sep 6, 2024

It should be required I'd say, unless there was some reason why notebooks would fail but still be mergable.

Let me try whether I have permission to set.

@ericspod ericspod merged commit b5766e5 into Project-MONAI:main Sep 6, 2024
6 checks passed
@KumoLiu KumoLiu mentioned this pull request Sep 6, 2024
5 tasks
pedrob37 pushed a commit to virginiafdez/tutorials that referenced this pull request Sep 6, 2024
Address some of Project-MONAI#1769.

### Description
These are the 2D ~~and 3D~~ DDPM tutorials. I have run them again to
verify they work. ~~The 2D ones are fine but the 3D tutorial keeps
having mode collapse or some other issue resulting in bad results. Work
is ongoing on this one.~~ I have left the 3D tutorial off since it's not
training stably and needs some revamp to be a proper and useful tutorial
for users.

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Avoid including large-size files in the PR.
- [x] Clean up long text outputs from code cells in the notebook.
- [x] For security purposes, please check the contents and remove any
sensitive info such as user names and private key.
- [x] Ensure (1) hyperlinks and markdown anchors are working (2) use
relative paths for tutorial repo files (3) put figure and graphs in the
`./figure` folder
- [x] Notebook runs automatically `./runner.sh -t <path to .ipynb file>`

---------

Signed-off-by: Eric Kerfoot <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: YunLiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants