-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor learn2reg_nlst_paired_lung_ct #1809
Conversation
Signed-off-by: YunLiu <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
Signed-off-by: YunLiu <[email protected]>
…into 3d-registration
Signed-off-by: YunLiu <[email protected]>
View / edit / reply to this conversation on ReviewNB ericspod commented on 2024-09-03T12:37:54Z Line #22. if self.ensure_channel_first: This should check that there isn't already a channel dimension. I think the KumoLiu commented on 2024-09-03T12:51:07Z Yes, use |
View / edit / reply to this conversation on ReviewNB ericspod commented on 2024-09-03T12:37:55Z Line #18. refer_keys=["fixed_image", "moving_image"], Why are we setting the affine for the points when they are being loaded when KumoLiu commented on 2024-09-03T12:43:38Z The reason why add the affine for the points when loading is that the points in this case is not at the world space. So the affine here will be used in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some comments on why some things were done but it looks correct regardless of that.
The reason why add the affine for the points when loading is that the points in this case is not at the world space. So the affine here will be used in View entire conversation on ReviewNB |
Signed-off-by: YunLiu <[email protected]>
Yes, use View entire conversation on ReviewNB |
Hey @KumoLiu Thanks |
Signed-off-by: YunLiu <[email protected]>
…into 3d-registration
refactor learn2reg_nlst_paired_lung_ct using ApplyTransformToPointsd
Checks
./figure
folder./runner.sh -t <path to .ipynb file>