Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor learn2reg_nlst_paired_lung_ct #1809

Merged
merged 11 commits into from
Sep 4, 2024

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Sep 3, 2024

refactor learn2reg_nlst_paired_lung_ct using ApplyTransformToPointsd

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

review-notebook-app bot commented Sep 3, 2024

View / edit / reply to this conversation on ReviewNB

ericspod commented on 2024-09-03T12:37:54Z
----------------------------------------------------------------

Line #22.                if self.ensure_channel_first:

This should check that there isn't already a channel dimension. I think the EnsureChannelFirstd transform should work with point data already anyway.


KumoLiu commented on 2024-09-03T12:51:07Z
----------------------------------------------------------------

Yes, use EnsureChannelFirstd instead. Thanks.

Copy link

review-notebook-app bot commented Sep 3, 2024

View / edit / reply to this conversation on ReviewNB

ericspod commented on 2024-09-03T12:37:55Z
----------------------------------------------------------------

Line #18.                refer_keys=["fixed_image", "moving_image"],

Why are we setting the affine for the points when they are being loaded when ApplyTransformToPointsd is going to be used later on? This affine values goes into the metadata of the points but isn't actually applied, and then ApplyTransformToPointsd doesn't use this anyway.


KumoLiu commented on 2024-09-03T12:43:38Z
----------------------------------------------------------------

The reason why add the affine for the points when loading is that the points in this case is not at the world space. So the affine here will be used in ApplyTransformToPointsd as a "already applied affine".

Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some comments on why some things were done but it looks correct regardless of that.

Copy link
Contributor Author

KumoLiu commented Sep 3, 2024

The reason why add the affine for the points when loading is that the points in this case is not at the world space. So the affine here will be used in ApplyTransformToPointsd as a "already applied affine".


View entire conversation on ReviewNB

Signed-off-by: YunLiu <[email protected]>
Copy link
Contributor Author

KumoLiu commented Sep 3, 2024

Yes, use EnsureChannelFirstd instead. Thanks.


View entire conversation on ReviewNB

@vikashg
Copy link
Contributor

vikashg commented Sep 3, 2024

Hey @KumoLiu
I will be able to go through this tonight.
Give me couple of hours

Thanks
Vikash

@KumoLiu KumoLiu merged commit 5c446bf into Project-MONAI:main Sep 4, 2024
6 checks passed
@KumoLiu KumoLiu deleted the 3d-registration branch September 4, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants