-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADd vista3d tutorial #1799
ADd vista3d tutorial #1799
Conversation
Signed-off-by: heyufan1995 <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
View / edit / reply to this conversation on ReviewNB KumoLiu commented on 2024-08-26T03:11:03Z Please help remove the output for this cell, thanks! |
View / edit / reply to this conversation on ReviewNB KumoLiu commented on 2024-08-26T03:11:03Z Line #3. AsDiscrete, Please help remove the unused import based on: https://github.com/Project-MONAI/tutorials/actions/runs/10530840790/job/29181611485?pr=1799#step:7:302 |
View / edit / reply to this conversation on ReviewNB KumoLiu commented on 2024-08-26T03:11:04Z Could you please help remove the error output from this cell? |
View / edit / reply to this conversation on ReviewNB KumoLiu commented on 2024-08-26T03:11:05Z Could you please help adjust the order here to the correct order of calls, and add one line for |
View / edit / reply to this conversation on ReviewNB KumoLiu commented on 2024-08-26T03:11:05Z Please help remove the output and check whether the model weights can be loaded correctly. Thanks! |
View / edit / reply to this conversation on ReviewNB KumoLiu commented on 2024-08-26T03:11:06Z Line #1. torch.load(os.path.join(root_dir, "model.pt")) Also for this cell. |
View / edit / reply to this conversation on ReviewNB KumoLiu commented on 2024-08-26T03:11:07Z Based on this: https://github.com/Project-MONAI/tutorials/actions/runs/10530840785/job/29181611520?pr=1799#step:7:8. Could you please edit the output from the source, keep only the first and last few lines. Thanks. |
View / edit / reply to this conversation on ReviewNB KumoLiu commented on 2024-08-26T03:11:08Z Line #2. from monai.transforms import LoadImage
Please move this import at top of file (Setup imports) |
View / edit / reply to this conversation on ReviewNB KumoLiu commented on 2024-08-26T03:11:08Z Please help only keep one or two line pictures here, thanks! |
View / edit / reply to this conversation on ReviewNB KumoLiu commented on 2024-08-26T03:11:09Z Line #1. test_outputs[0].meta["filename_or_obj"] I guess this cell can be removed? |
Hi @heyufan1995, thanks for the PR! Overall looks good to me, just leave several comments in line. |
Please also update this README file: https://github.com/Project-MONAI/tutorials/blob/main/README.md |
Signed-off-by: heyufan1995 <[email protected]>
for more information, see https://pre-commit.ci
Hi @heyufan1995, thanks for the update, please also update the README file here: https://github.com/Project-MONAI/tutorials/blob/main/README.md#3d-segmentation. |
Signed-off-by: heyufan1995 <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Fixes # .
Description
A few sentences describing the changes proposed in this pull request.
Checks
./figure
folder./runner.sh -t <path to .ipynb file>