Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADd vista3d tutorial #1799

Merged
merged 15 commits into from
Sep 2, 2024
Merged

ADd vista3d tutorial #1799

merged 15 commits into from
Sep 2, 2024

Conversation

heyufan1995
Copy link
Member

Fixes # .

Description

A few sentences describing the changes proposed in this pull request.

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Signed-off-by: heyufan1995 <[email protected]>
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

review-notebook-app bot commented Aug 26, 2024

View / edit / reply to this conversation on ReviewNB

KumoLiu commented on 2024-08-26T03:11:03Z
----------------------------------------------------------------

Please help remove the output for this cell, thanks!


Copy link

review-notebook-app bot commented Aug 26, 2024

View / edit / reply to this conversation on ReviewNB

KumoLiu commented on 2024-08-26T03:11:03Z
----------------------------------------------------------------

Line #3.        AsDiscrete,

Please help remove the unused import based on: https://github.com/Project-MONAI/tutorials/actions/runs/10530840790/job/29181611485?pr=1799#step:7:302


Copy link

review-notebook-app bot commented Aug 26, 2024

View / edit / reply to this conversation on ReviewNB

KumoLiu commented on 2024-08-26T03:11:04Z
----------------------------------------------------------------

Could you please help remove the error output from this cell?


Copy link

review-notebook-app bot commented Aug 26, 2024

View / edit / reply to this conversation on ReviewNB

KumoLiu commented on 2024-08-26T03:11:05Z
----------------------------------------------------------------

Could you please help adjust the order here to the correct order of calls, and add one line for Relabeld?


Copy link

review-notebook-app bot commented Aug 26, 2024

View / edit / reply to this conversation on ReviewNB

KumoLiu commented on 2024-08-26T03:11:05Z
----------------------------------------------------------------

Please help remove the output and check whether the model weights can be loaded correctly. Thanks!


Copy link

review-notebook-app bot commented Aug 26, 2024

View / edit / reply to this conversation on ReviewNB

KumoLiu commented on 2024-08-26T03:11:06Z
----------------------------------------------------------------

Line #1.    torch.load(os.path.join(root_dir, "model.pt"))

Also for this cell.


Copy link

review-notebook-app bot commented Aug 26, 2024

View / edit / reply to this conversation on ReviewNB

KumoLiu commented on 2024-08-26T03:11:07Z
----------------------------------------------------------------

Based on this: https://github.com/Project-MONAI/tutorials/actions/runs/10530840785/job/29181611520?pr=1799#step:7:8.

Could you please edit the output from the source, keep only the first and last few lines. Thanks.


Copy link

review-notebook-app bot commented Aug 26, 2024

View / edit / reply to this conversation on ReviewNB

KumoLiu commented on 2024-08-26T03:11:08Z
----------------------------------------------------------------

Line #2.    from monai.transforms import LoadImage

Based on: https://github.com/Project-MONAI/tutorials/actions/runs/10530840790/job/29181611485?pr=1799#step:7:323

Please move this import at top of file (Setup imports)


Copy link

review-notebook-app bot commented Aug 26, 2024

View / edit / reply to this conversation on ReviewNB

KumoLiu commented on 2024-08-26T03:11:08Z
----------------------------------------------------------------

Please help only keep one or two line pictures here, thanks!


Copy link

review-notebook-app bot commented Aug 26, 2024

View / edit / reply to this conversation on ReviewNB

KumoLiu commented on 2024-08-26T03:11:09Z
----------------------------------------------------------------

Line #1.    test_outputs[0].meta["filename_or_obj"]

I guess this cell can be removed?


@KumoLiu
Copy link
Contributor

KumoLiu commented Aug 26, 2024

Hi @heyufan1995, thanks for the PR! Overall looks good to me, just leave several comments in line.
And does this checkpoint used in the tutorial the same as the model zoo? If yes I guess we may include the license info here?
cc @yiheng-wang-nv @mingxin-zheng @Nic-Ma

@KumoLiu
Copy link
Contributor

KumoLiu commented Aug 26, 2024

Please also update this README file: https://github.com/Project-MONAI/tutorials/blob/main/README.md

@KumoLiu
Copy link
Contributor

KumoLiu commented Aug 29, 2024

Hi @heyufan1995, thanks for the update, please also update the README file here: https://github.com/Project-MONAI/tutorials/blob/main/README.md#3d-segmentation.

Signed-off-by: YunLiu <[email protected]>
@KumoLiu KumoLiu merged commit 126c99c into Project-MONAI:main Sep 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants