Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorials under reconstruction folder #1671

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Mar 20, 2024

Fixes #1670

Description

Set "image_only=False" in LoadImage.

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Signed-off-by: YunLiu <[email protected]>
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to fix things here, we could change ExtractDataKeyFromMetaKeyd to try and pull from the metadata of a MetaTensor later to work with image_only=True.

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Mar 20, 2024

Agree, ticket here: Project-MONAI/MONAI#7562.

@KumoLiu KumoLiu merged commit 34951f3 into Project-MONAI:main Mar 20, 2024
6 checks passed
@KumoLiu KumoLiu deleted the reconstruction branch March 26, 2024 01:59
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
Fixes Project-MONAI#1670

### Description
Set "image_only=False" in `LoadImage`.

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [ ] Avoid including large-size files in the PR.
- [ ] Clean up long text outputs from code cells in the notebook.
- [ ] For security purposes, please check the contents and remove any
sensitive info such as user names and private key.
- [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use
relative paths for tutorial repo files (3) put figure and graphs in the
`./figure` folder
- [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>`

---------

Signed-off-by: YunLiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError in "reconstruction/MRI_reconstruction/unet_demo/inference.ipynb"
2 participants