-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TensorBoardStatsHandler for 2d_classfication #1650
Conversation
Signed-off-by: YunLiu <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Extending from our conversation just now on a MONAI 201 notebook, I used this pattern with the bundle tutorials with 03_mednist_classification_v2.ipynb. This is the pattern I'd suggest of a lesson building on a previous one. |
Signed-off-by: YunLiu <[email protected]>
for more information, see https://pre-commit.ci
This reverts commit b6a83da. Signed-off-by: YunLiu <[email protected]>
…-cls Signed-off-by: YunLiu <[email protected]>
Hi @ericspod, do you think for this one we also need to add another tutorial since there only three lines were added? |
Signed-off-by: YunLiu <[email protected]>
For this notebook maybe these additions are fine, the monai_101.ipynb was the super-simple notebook I wanted to keep small. Since you're using Tensorboard, is there something that can be added to demonstrate that data within the notebook? I don't know if including Tensorboard in the notebook will render correctly in Github. |
Signed-off-by: YunLiu <[email protected]>
Hi @ericspod, I have added this part, could you please help review it again, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Fixes Project-MONAI#1649 ### Description Add TensorBoardStatsHandler for 2d_classfication ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [ ] Avoid including large-size files in the PR. - [ ] Clean up long text outputs from code cells in the notebook. - [ ] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: YunLiu <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Fixes #1649
Description
Add TensorBoardStatsHandler for 2d_classfication
Checks
./figure
folder./runner.sh -t <path to .ipynb file>