Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TensorBoardStatsHandler for 2d_classfication #1650

Merged
merged 8 commits into from
Feb 29, 2024

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Feb 22, 2024

Fixes #1649

Description

Add TensorBoardStatsHandler for 2d_classfication

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Signed-off-by: YunLiu <[email protected]>
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ericspod
Copy link
Member

Extending from our conversation just now on a MONAI 201 notebook, I used this pattern with the bundle tutorials with 03_mednist_classification_v2.ipynb. This is the pattern I'd suggest of a lesson building on a previous one.

Signed-off-by: YunLiu <[email protected]>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Feb 26, 2024

Hi @ericspod, do you think for this one we also need to add another tutorial since there only three lines were added?
https://github.com/Project-MONAI/tutorials/blob/39ecb41b480cf2438a3e3d4da9119a2cc26b89a1/2d_classification/mednist_tutorial.ipynb

Signed-off-by: YunLiu <[email protected]>
@ericspod
Copy link
Member

Hi @ericspod, do you think for this one we also need to add another tutorial since there only three lines were added?
https://github.com/Project-MONAI/tutorials/blob/39ecb41b480cf2438a3e3d4da9119a2cc26b89a1/2d_classification/mednist_tutorial.ipynb

For this notebook maybe these additions are fine, the monai_101.ipynb was the super-simple notebook I wanted to keep small. Since you're using Tensorboard, is there something that can be added to demonstrate that data within the notebook? I don't know if including Tensorboard in the notebook will render correctly in Github.

Signed-off-by: YunLiu <[email protected]>
@KumoLiu KumoLiu marked this pull request as ready for review February 27, 2024 09:19
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Feb 28, 2024

Since you're using Tensorboard, is there something that can be added to demonstrate that data within the notebook? I don't know if including Tensorboard in the notebook will render correctly in Github.

Hi @ericspod, I have added this part, could you please help review it again, thanks!

Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@KumoLiu KumoLiu enabled auto-merge (squash) February 29, 2024 02:36
@KumoLiu KumoLiu merged commit 2920135 into Project-MONAI:main Feb 29, 2024
6 checks passed
@KumoLiu KumoLiu deleted the 2d-cls branch March 1, 2024 02:46
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
Fixes Project-MONAI#1649

### Description

Add TensorBoardStatsHandler for 2d_classfication

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [ ] Avoid including large-size files in the PR.
- [ ] Clean up long text outputs from code cells in the notebook.
- [ ] For security purposes, please check the contents and remove any
sensitive info such as user names and private key.
- [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use
relative paths for tutorial repo files (3) put figure and graphs in the
`./figure` folder
- [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>`

---------

Signed-off-by: YunLiu <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TensorBoardStatsHandler in 2d_classfication
2 participants