Skip to content

Commit

Permalink
Update dependencies & remove older version of .NET
Browse files Browse the repository at this point in the history
Signed-off-by: Victor Chang <[email protected]>
  • Loading branch information
mocsharp committed Dec 20, 2023
1 parent 952e3d2 commit da29917
Show file tree
Hide file tree
Showing 115 changed files with 3,407 additions and 4,471 deletions.
2 changes: 1 addition & 1 deletion src/Api/LoggingDataDictionary.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

namespace Monai.Deploy.InformaticsGateway.Api
{
[Serializable]

public class LoggingDataDictionary<TKey, TValue> : Dictionary<TKey, TValue> where TKey : notnull

Check warning on line 27 in src/Api/LoggingDataDictionary.cs

View workflow job for this annotation

GitHub Actions / unit-test

Update this implementation of 'ISerializable' to conform to the recommended serialization pattern. (https://rules.sonarsource.com/csharp/RSPEC-3925)
{
public LoggingDataDictionary()
Expand Down
6 changes: 3 additions & 3 deletions src/Api/Monai.Deploy.InformaticsGateway.Api.csproj
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!--
<!--
~ Copyright 2021-2023 MONAI Consortium
~
~ Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -51,8 +51,8 @@
<PackageReference Include="fo-dicom" Version="5.1.1" />
<PackageReference Include="HL7-dotnetcore" Version="2.36.0" />
<PackageReference Include="Macross.Json.Extensions" Version="3.0.0" />
<PackageReference Include="Monai.Deploy.Messaging" Version="1.0.5" />
<PackageReference Include="Monai.Deploy.Messaging.RabbitMQ" Version="1.0.5" />
<PackageReference Include="Monai.Deploy.Messaging" Version="1.0.6" />
<PackageReference Include="Monai.Deploy.Messaging.RabbitMQ" Version="1.0.6" />
<PackageReference Include="Monai.Deploy.Storage" Version="0.2.18" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Abstractions" Version="8.0.0" />
</ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/Api/Rest/InferenceRequestException.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ namespace Monai.Deploy.InformaticsGateway.Api.Rest
/// <summary>
/// Inference request exception.
/// </summary>
[Serializable]

public class InferenceRequestException : Exception

Check warning on line 27 in src/Api/Rest/InferenceRequestException.cs

View workflow job for this annotation

GitHub Actions / unit-test

Update this implementation of 'ISerializable' to conform to the recommended serialization pattern. (https://rules.sonarsource.com/csharp/RSPEC-3925)
{
public InferenceRequestException()
Expand Down
3 changes: 0 additions & 3 deletions src/Api/Storage/FileStorageMetadata.cs
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,6 @@ public abstract record FileStorageMetadata
[JsonPropertyName("payloadId")]
public string? PayloadId { get; set; }

// [JsonPropertyName("destinationFolder")]
//public string? DestinationFolderNeil { get; set; }

/// <summary>
/// DO NOT USE
/// This constructor is intended for JSON serializer.
Expand Down
6 changes: 3 additions & 3 deletions src/Api/Test/Monai.Deploy.InformaticsGateway.Api.Test.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.2" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
<PackageReference Include="System.IO.Abstractions.TestingHelpers" Version="17.2.3" />
<PackageReference Include="xRetry" Version="1.9.0" />
<PackageReference Include="xunit" Version="2.5.0" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.0">
<PackageReference Include="xunit" Version="2.6.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.5">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
Expand Down
91 changes: 44 additions & 47 deletions src/Api/Test/packages.lock.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@
},
"Microsoft.NET.Test.Sdk": {
"type": "Direct",
"requested": "[17.7.2, )",
"resolved": "17.7.2",
"contentHash": "WOSF/GUYcnrLGkdvCbXDRig2rShtBwfQc5l7IxQE6PZI3CeXAqF1SpyzwlGA5vw+MdEAXs3niy+ZkGBBWna6tw==",
"requested": "[17.8.0, )",
"resolved": "17.8.0",
"contentHash": "BmTYGbD/YuDHmApIENdoyN1jCk0Rj1fJB0+B/fVekyTdVidr91IlzhqzytiUgaEAzL1ZJcYCme0MeBMYvJVzvw==",
"dependencies": {
"Microsoft.CodeCoverage": "17.7.2",
"Microsoft.TestPlatform.TestHost": "17.7.2"
"Microsoft.CodeCoverage": "17.8.0",
"Microsoft.TestPlatform.TestHost": "17.8.0"
}
},
"System.IO.Abstractions.TestingHelpers": {
Expand All @@ -38,25 +38,25 @@
},
"xunit": {
"type": "Direct",
"requested": "[2.5.0, )",
"resolved": "2.5.0",
"contentHash": "f2V5wuAdoaq0mRTt9UBmPbVex9HcwFYn+y7WaKUz5Xpakcrv7lhtQWBJUWNY4N3Z+o+atDBLyAALM1QWx04C6Q==",
"requested": "[2.6.3, )",
"resolved": "2.6.3",
"contentHash": "4CoGp3iKZORZ9aaHdPrFcdlDBRI/ZFRyDZWJuP7r2idULEtWf+k0yGT80cF/v6nE/MQDXLMIuSGDIrHuPLC/+Q==",
"dependencies": {
"xunit.analyzers": "1.2.0",
"xunit.assert": "2.5.0",
"xunit.core": "[2.5.0]"
"xunit.analyzers": "1.7.0",
"xunit.assert": "2.6.3",
"xunit.core": "[2.6.3]"
}
},
"xunit.runner.visualstudio": {
"type": "Direct",
"requested": "[2.5.0, )",
"resolved": "2.5.0",
"contentHash": "+Gp9vuC2431yPyKB15YrOTxCuEAErBQUTIs6CquumX1F073UaPHGW0VE/XVJLMh9W4sXdz3TBkcHdFWZrRn2Hw=="
"requested": "[2.5.5, )",
"resolved": "2.5.5",
"contentHash": "AJsBBn8S00ZxdXPSIp8s+NcBQMO9tcll1UVCfGNoEi1DUH2z3f4Y1epV9nYbhgG6wFoTKJP6YuLT2MeTPV9gnA=="
},
"Ardalis.GuardClauses": {
"type": "Transitive",
"resolved": "4.1.1",
"contentHash": "+UcJ2s+gf2wMNrwadCaHZV2DMcGgBU1t22A+jm40P4MHQRLy9hcleGy5xdVWd4dXZPa5Vlp4TG5xU2rhoDYrBA=="
"resolved": "4.2.0",
"contentHash": "2mDznNQkPRNpTVGrThEVhBTtxBUsCMobLnfOXnhehznwIEDjT0PG+1cedYzVhHHPfzU1OGc/2ubEkFAyoBi4LQ=="
},
"AWSSDK.Core": {
"type": "Transitive",
Expand Down Expand Up @@ -116,8 +116,8 @@
},
"Microsoft.CodeCoverage": {
"type": "Transitive",
"resolved": "17.7.2",
"contentHash": "ntbkwIqwszkfCRjxVZOyEQiHauiYsY9NtYjw9ASsoxDSiG8YtV6AGcOAwrAk3TZv2UOq4MrpX+3MYEeMHSb03w=="
"resolved": "17.8.0",
"contentHash": "KC8SXWbGIdoFVdlxKk9WHccm0llm9HypcHMLUUFabRiTS3SO2fQXNZfdiF3qkEdTJhbRrxhdRxjL4jbtwPq4Ew=="
},
"Microsoft.EntityFrameworkCore.Abstractions": {
"type": "Transitive",
Expand Down Expand Up @@ -226,19 +226,19 @@
},
"Microsoft.TestPlatform.ObjectModel": {
"type": "Transitive",
"resolved": "17.7.2",
"contentHash": "aHzQWgDMVBnk39HhQVmn06w+YxzF1h2V5/M4WgrNQAn7q97GR4Si3vLRTDlmJo9nK/Nknce+H4tXx4gqOKyLeg==",
"resolved": "17.8.0",
"contentHash": "AYy6vlpGMfz5kOFq99L93RGbqftW/8eQTqjT9iGXW6s9MRP3UdtY8idJ8rJcjeSja8A18IhIro5YnH3uv1nz4g==",
"dependencies": {
"NuGet.Frameworks": "6.5.0",
"System.Reflection.Metadata": "1.6.0"
}
},
"Microsoft.TestPlatform.TestHost": {
"type": "Transitive",
"resolved": "17.7.2",
"contentHash": "pv9yVD7IKPLJV28zYjLsWFiM3j506I2ye+6NquG8vsbm/gR7lgyig8IgY6Vo57VMvGaAKwtUECzcj+C5tH271Q==",
"resolved": "17.8.0",
"contentHash": "9ivcl/7SGRmOT0YYrHQGohWiT5YCpkmy/UEzldfVisLm6QxbLaK3FAJqZXI34rnRLmqqDCeMQxKINwmKwAPiDw==",
"dependencies": {
"Microsoft.TestPlatform.ObjectModel": "17.7.2",
"Microsoft.TestPlatform.ObjectModel": "17.8.0",
"Newtonsoft.Json": "13.0.1"
}
},
Expand All @@ -254,8 +254,8 @@
},
"Monai.Deploy.Messaging": {
"type": "Transitive",
"resolved": "1.0.5",
"contentHash": "J8Lskfy8PSVQLDE2uLqh53uaPpqpRJuSGVHpR2jrw+GYnTTDv21j/2gxwG8Hq2NgNOkWLNVi+fFnyWd6WFiUTA==",
"resolved": "1.0.6",
"contentHash": "A4yyvJ0E01aKcCa8lF0gadiEAqe6AYVdmm3afjom+E89+n6oKydTbXYPYWDtUVPW1iAWtLS/BuOxBHRSljKmig==",
"dependencies": {
"Ardalis.GuardClauses": "4.1.1",
"Microsoft.Extensions.Diagnostics.HealthChecks": "6.0.21",
Expand All @@ -265,10 +265,10 @@
},
"Monai.Deploy.Messaging.RabbitMQ": {
"type": "Transitive",
"resolved": "1.0.5",
"contentHash": "L+BWU5Xq1ARjFRcpnefDJGuG52Zw4Iz3qql1tn8lYfqoC4B37fAUVz6k7Ar7v1OUwPo/JR8q4OP2IIMpqpKRRA==",
"resolved": "1.0.6",
"contentHash": "Ka4K58/brPHv/GiUdiWsKPvnesfNqYrSN3GVa1sRp6iAGSmO7QA1Yl5/Pd/q494U55OGNI9JPtEbQZUx6G4/nQ==",
"dependencies": {
"Monai.Deploy.Messaging": "1.0.5",
"Monai.Deploy.Messaging": "1.0.6",
"Polly": "7.2.4",
"RabbitMQ.Client": "6.5.0"
}
Expand Down Expand Up @@ -1241,42 +1241,39 @@
},
"xunit.analyzers": {
"type": "Transitive",
"resolved": "1.2.0",
"contentHash": "d3dehV/DASLRlR8stWQmbPPjfYC2tct50Evav+OlsJMkfFqkhYvzO1k0s81lk0px8O0knZU/FqC8SqbXOtn+hw=="
"resolved": "1.7.0",
"contentHash": "lAcpaB0KnjWETbPDMsDPoQi6zS0uXUYopmyTQDWvILJWcL9jwMxXXGmDLptlMA6vGi5Z0LtudsYN+dEUTmuHaA=="
},
"xunit.assert": {
"type": "Transitive",
"resolved": "2.5.0",
"contentHash": "wN84pKX5jzfpgJ0bB6arrCA/oelBeYLCpnQ9Wj5xGEVPydKzVSDY5tEatFLHE/rO0+0RC+I4H5igGE118jRh1w==",
"dependencies": {
"NETStandard.Library": "1.6.1"
}
"resolved": "2.6.3",
"contentHash": "7JWrjxDIAwF1vBZyENu4BZaddNJijIQcIQcc+73sJPWaqzDmseysTYv2jR0IWBsWIGa6LSfMO/3+dH0fsHL5Wg=="
},
"xunit.core": {
"type": "Transitive",
"resolved": "2.5.0",
"contentHash": "dnV0Mn2s1C0y2m33AylQyMkEyhBQsL4R0302kwSGiEGuY3JwzEmhTa9pnghyMRPliYSs4fXfkEAP+5bKXryGFg==",
"resolved": "2.6.3",
"contentHash": "rlrm//9cNAlCkh3p5mdggzfchZlcXowUVK3UPqKiaN7G0Wu7gOUNLLZej9twnwTCVe1h3FEi9PRwzXMMXpFwSQ==",
"dependencies": {
"xunit.extensibility.core": "[2.5.0]",
"xunit.extensibility.execution": "[2.5.0]"
"xunit.extensibility.core": "[2.6.3]",
"xunit.extensibility.execution": "[2.6.3]"
}
},
"xunit.extensibility.core": {
"type": "Transitive",
"resolved": "2.5.0",
"contentHash": "xRm6NIV3i7I+LkjsAJ91Xz2fxJm/oMEi2CYq1G5HlGTgcK1Zo2wNbLO6nKX1VG5FZzXibSdoLwr/MofVvh3mFA==",
"resolved": "2.6.3",
"contentHash": "qWCpmK4nxFBsf68r35AgnrW6B+xjTCpjJYfJkaBaini4Myl/2P/Ro6WocVtJfpHilkatitVFgM3XVR0jthdJlQ==",
"dependencies": {
"NETStandard.Library": "1.6.1",
"xunit.abstractions": "2.0.3"
}
},
"xunit.extensibility.execution": {
"type": "Transitive",
"resolved": "2.5.0",
"contentHash": "7+v2Bvp+1ew1iMGQVb1glICi8jcNdHbRUX6Ru0dmJBViGdjiS7kyqcX2VxleQhFbKNi+WF0an7/TeTXD283RlQ==",
"resolved": "2.6.3",
"contentHash": "I+9OA9a6WVia40bxJi3KaxVcjTE1ouHqD0QcrjHA/hLl7Ozb5eQmV7ecLu3gRZlPLdcVN+If8IZcEmqytmLtkA==",
"dependencies": {
"NETStandard.Library": "1.6.1",
"xunit.extensibility.core": "[2.5.0]"
"xunit.extensibility.core": "[2.6.3]"
}
},
"monai.deploy.informaticsgateway.api": {
Expand All @@ -1286,16 +1283,16 @@
"Macross.Json.Extensions": "[3.0.0, )",
"Microsoft.EntityFrameworkCore.Abstractions": "[8.0.0, )",
"Monai.Deploy.InformaticsGateway.Common": "[1.0.0, )",
"Monai.Deploy.Messaging": "[1.0.5, )",
"Monai.Deploy.Messaging.RabbitMQ": "[1.0.5, )",
"Monai.Deploy.Messaging": "[1.0.6, )",
"Monai.Deploy.Messaging.RabbitMQ": "[1.0.6, )",
"Monai.Deploy.Storage": "[0.2.18, )",
"fo-dicom": "[5.1.1, )"
}
},
"monai.deploy.informaticsgateway.common": {
"type": "Project",
"dependencies": {
"Ardalis.GuardClauses": "[4.1.1, )",
"Ardalis.GuardClauses": "[4.2.0, )",
"System.IO.Abstractions": "[17.2.3, )"
}
}
Expand Down
20 changes: 10 additions & 10 deletions src/Api/packages.lock.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@
},
"Monai.Deploy.Messaging": {
"type": "Direct",
"requested": "[1.0.5, )",
"resolved": "1.0.5",
"contentHash": "J8Lskfy8PSVQLDE2uLqh53uaPpqpRJuSGVHpR2jrw+GYnTTDv21j/2gxwG8Hq2NgNOkWLNVi+fFnyWd6WFiUTA==",
"requested": "[1.0.6, )",
"resolved": "1.0.6",
"contentHash": "A4yyvJ0E01aKcCa8lF0gadiEAqe6AYVdmm3afjom+E89+n6oKydTbXYPYWDtUVPW1iAWtLS/BuOxBHRSljKmig==",
"dependencies": {
"Ardalis.GuardClauses": "4.1.1",
"Microsoft.Extensions.Diagnostics.HealthChecks": "6.0.21",
Expand All @@ -59,11 +59,11 @@
},
"Monai.Deploy.Messaging.RabbitMQ": {
"type": "Direct",
"requested": "[1.0.5, )",
"resolved": "1.0.5",
"contentHash": "L+BWU5Xq1ARjFRcpnefDJGuG52Zw4Iz3qql1tn8lYfqoC4B37fAUVz6k7Ar7v1OUwPo/JR8q4OP2IIMpqpKRRA==",
"requested": "[1.0.6, )",
"resolved": "1.0.6",
"contentHash": "Ka4K58/brPHv/GiUdiWsKPvnesfNqYrSN3GVa1sRp6iAGSmO7QA1Yl5/Pd/q494U55OGNI9JPtEbQZUx6G4/nQ==",
"dependencies": {
"Monai.Deploy.Messaging": "1.0.5",
"Monai.Deploy.Messaging": "1.0.6",
"Polly": "7.2.4",
"RabbitMQ.Client": "6.5.0"
}
Expand All @@ -82,8 +82,8 @@
},
"Ardalis.GuardClauses": {
"type": "Transitive",
"resolved": "4.1.1",
"contentHash": "+UcJ2s+gf2wMNrwadCaHZV2DMcGgBU1t22A+jm40P4MHQRLy9hcleGy5xdVWd4dXZPa5Vlp4TG5xU2rhoDYrBA=="
"resolved": "4.2.0",
"contentHash": "2mDznNQkPRNpTVGrThEVhBTtxBUsCMobLnfOXnhehznwIEDjT0PG+1cedYzVhHHPfzU1OGc/2ubEkFAyoBi4LQ=="
},
"AWSSDK.Core": {
"type": "Transitive",
Expand Down Expand Up @@ -292,7 +292,7 @@
"monai.deploy.informaticsgateway.common": {
"type": "Project",
"dependencies": {
"Ardalis.GuardClauses": "[4.1.1, )",
"Ardalis.GuardClauses": "[4.2.0, )",
"System.IO.Abstractions": "[17.2.3, )"
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/CLI/Commands/AetCommand.cs
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ private async Task<int> ListAeTitlehandlerAsync(IHost host, bool verbose, Cancel
Guard.Against.Null(client, nameof(client), $"{Strings.ApplicationName} client is unavailable.");
Guard.Against.Null(consoleRegion, nameof(consoleRegion), "Console region is unavailable.");

IReadOnlyList<MonaiApplicationEntity> items = null;
IReadOnlyList<MonaiApplicationEntity>? items = null;
try
{
CheckConfiguration(configService);
Expand Down Expand Up @@ -390,7 +390,7 @@ private async Task<int> ListPlugInsHandlerAsync(IHost host, bool verbose, Cancel
Guard.Against.Null(client, nameof(client), $"{Strings.ApplicationName} client is unavailable.");
Guard.Against.Null(consoleRegion, nameof(consoleRegion), "Console region is unavailable.");

IDictionary<string, string> items = null;
IDictionary<string, string>? items = null;
try
{
CheckConfiguration(configService);
Expand Down
2 changes: 1 addition & 1 deletion src/CLI/Commands/CommandBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public CommandBase(string name, string description) : base(name, description)
{
}

protected static ILogger CreateLogger<T>(IHost host)
protected static ILogger? CreateLogger<T>(IHost host)
{
Guard.Against.Null(host, nameof(host));

Expand Down
2 changes: 1 addition & 1 deletion src/CLI/Commands/ConfigurationException.cs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

namespace Monai.Deploy.InformaticsGateway.CLI
{
[Serializable]

public class ConfigurationException : Exception
{
private ConfigurationException()
Expand Down
18 changes: 1 addition & 17 deletions src/CLI/ControlException.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,10 @@
*/

using System;
using System.Runtime.Serialization;
using Ardalis.GuardClauses;

namespace Monai.Deploy.InformaticsGateway.CLI
{
[Serializable]

public class ControlException : Exception
{
public int ErrorCode { get; }
Expand All @@ -41,19 +39,5 @@ public ControlException(int errorCode, string message) : base(message)
{
ErrorCode = errorCode;
}

protected ControlException(SerializationInfo info, StreamingContext context) : base(info, context)
{
ErrorCode = info.GetInt32(nameof(ErrorCode));
}

public override void GetObjectData(SerializationInfo info, StreamingContext context)
{
Guard.Against.Null(info, nameof(info));

info.AddValue(nameof(ErrorCode), ErrorCode);

base.GetObjectData(info, context);
}
}
}
1 change: 1 addition & 0 deletions src/CLI/Monai.Deploy.InformaticsGateway.CLI.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
<CodeAnalysisRuleSet>..\.sonarlint\project-monai_monai-deploy-informatics-gatewaycsharp.ruleset</CodeAnalysisRuleSet>
<RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
<Nullable>enable</Nullable>
</PropertyGroup>
<ItemGroup>
<Compile Remove="Test\**" />
Expand Down
8 changes: 4 additions & 4 deletions src/CLI/Test/Monai.Deploy.InformaticsGateway.CLI.Test.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.2" />
<PackageReference Include="Moq" Version="4.20.69" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
<PackageReference Include="Moq" Version="4.20.70" />
<PackageReference Include="System.CommandLine.Hosting" Version="0.4.0-alpha.22272.1" />
<PackageReference Include="System.IO.Abstractions.TestingHelpers" Version="17.2.3" />
<PackageReference Include="xRetry" Version="1.9.0" />
<PackageReference Include="xunit" Version="2.5.0" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.0">
<PackageReference Include="xunit" Version="2.6.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.5">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
Expand Down
Loading

0 comments on commit da29917

Please sign in to comment.