-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server for VILA-M3 integrated to the slicer module #66
base: main
Are you sure you want to change the base?
Conversation
diazandr3s
commented
Jan 29, 2025
•
edited
Loading
edited
- Server working for NVCF functions to interact with 3D Slicer
- This model works from images pre loaded to NVCF
@mingxin-zheng could you please review and approve? :) |
Hi @adiazpinto , thanks for the PR. Are you importing these from util.py?
Some of the classes above are in that file, but some are not. Also, it worth noting that streaming mode isn't supported at the moment. I saw you have an implementation in the server, but it is unclear to me how that would be enabled for the internal NVCF function or local server setup in the repo. Thanks! |
Thanks again, @mingxin-zheng. |
class ExpertVista3D(): | ||
"""Expert model for VISTA-3D.""" | ||
|
||
NIM_VISTA3D = "https://api.nvcf.nvidia.com/v2/nvcf/pexec/functions/caf65f74-1c04-4b3c-b566-5908ee950f24" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @diazandr3s
This is an internal NVCF. Having it exposed in the code is not intended.
) | ||
logger.info(f"Model {self.model_name} loaded successfully. Context length: {self.context_len}") | ||
elif source == "nim": | ||
self.base_url = "https://api.nvcf.nvidia.com/v2/nvcf/pexec/functions/a2dec46a-b444-45aa-a1fc-a510ca41f186" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above. Thanks!
|
||
REMOTE_URL = "https://developer.download.nvidia.com/assets/Clara/monai/samples" | ||
|
||
MODEL_CARDS = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some variables, classes and functions in this script are exactly the same as the ones in utils.py
Can we include the utils.py
in the PYTHON path and import them to avoid duplicate code? Thanks!