Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub workflows to lint code scripts and copyright #5

Merged
merged 10 commits into from
Sep 23, 2024

Conversation

mingxin-zheng
Copy link
Collaborator

No description provided.

Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng mingxin-zheng changed the title Add isort code linting Add GitHub workflows to lint code scripts and copyright Sep 23, 2024
@mingxin-zheng
Copy link
Collaborator Author

We plan to take two-step approach:

  1. First we add all necessary checks, and make them optional.
  2. After fixing all the errors in the main, we will make the check this mandatory for PRs to be merge into main

Signed-off-by: Mingxin Zheng <[email protected]>
Copy link
Collaborator

@holgerroth holgerroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mingxin-zheng mingxin-zheng merged commit b458d47 into main Sep 23, 2024
0 of 2 checks passed
@mingxin-zheng mingxin-zheng deleted the mingxinz/gh_workflow branch September 23, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants