Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gradio app issues #23

Merged
merged 4 commits into from
Oct 20, 2024
Merged

Fix gradio app issues #23

merged 4 commits into from
Oct 20, 2024

Conversation

mingxin-zheng
Copy link
Collaborator

@mingxin-zheng mingxin-zheng commented Oct 18, 2024 •
edited
Loading

This PR includes the following improvements/fixes:

  • Set the example prompts based on modality
  • Add a disclaimer
  • Add a statement saying “Please ask a question about the current image or 2D slice”
  • Add 1 more image example (CT)

@mingxin-zheng mingxin-zheng changed the title Mingxinz/gr improve Fix gradio app issues Oct 18, 2024
holgerroth
holgerroth reviewed Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@holgerroth holgerroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but two example questions seem irrelevant. See my comment.

@mingxin-zheng
Copy link
Collaborator Author

I think the two example questions are to count the liver tumors in the CT image. I removed them already. Thanks @holgerroth

holgerroth
holgerroth approved these changes Oct 20, 2024
View reviewed changes
Copy link
Collaborator

@holgerroth holgerroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@holgerroth holgerroth merged commit 96e0766 into main Oct 20, 2024
3 checks passed
@mingxin-zheng mingxin-zheng deleted the mingxinz/gr_improve branch October 20, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerroth holgerroth holgerroth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mingxin-zheng @holgerroth