Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PythonicWorkflow #8151

Merged
merged 44 commits into from
Nov 27, 2024
Merged

Add PythonicWorkflow #8151

merged 44 commits into from
Nov 27, 2024

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Oct 15, 2024

Fixes # .

Description

Add PythonicWorkflow

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu KumoLiu marked this pull request as draft October 15, 2024 14:19
@KumoLiu
minor update
7228989 
Signed-off-by: YunLiu <[email protected]>
This was referenced Oct 23, 2024
Open
Closed
Closed
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Nov 6, 2024

Hi @KumoLiu ,

Could you please add some unit tests and maybe we can start reviewing and merging this PR?

Thanks.

@KumoLiu KumoLiu marked this pull request as ready for review November 11, 2024 08:40
@KumoLiu
update docstring
6eed10d 
Signed-off-by: YunLiu <[email protected]>
binliunls
binliunls reviewed Nov 15, 2024
View reviewed changes
tests/test_bundle_workflow.py Outdated Show resolved Hide resolved
tests/test_bundle_workflow.py Show resolved Hide resolved
@KumoLiu KumoLiu requested review from binliunls and Nic-Ma November 15, 2024 08:37
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Nov 25, 2024

Hi @ericspod @Nic-Ma @binliunls @yiheng-wang-nv, do you have any further comments on this PR?

ericspod
ericspod approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good now, let's get people using this and see about feedback. Thanks!

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Nov 27, 2024

/build

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Nov 27, 2024

/build

@KumoLiu KumoLiu merged commit e73257c into Project-MONAI:dev Nov 27, 2024
28 checks passed
@KumoLiu KumoLiu deleted the pythonicworkflow branch November 27, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericspod ericspod ericspod approved these changes

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@yiheng-wang-nv yiheng-wang-nv Awaiting requested review from yiheng-wang-nv

@binliunls binliunls Awaiting requested review from binliunls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KumoLiu @Nic-Ma @ericspod @yiheng-wang-nv @binliunls @borisfom